All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kristian Edlund <edlund@groenstue.dk>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] Typos in Documation/kbuild/modules.txt 2.6.15-rc2
Date: Tue, 22 Nov 2005 23:02:56 +0100	[thread overview]
Message-ID: <43839590.5050409@groenstue.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0511220855380.13959@g5.osdl.org>

Linus Torvalds wrote:

>Seriously whitespace-damaged (lost spaces not just at the end of lines, 
>but at their beginning too - and wordwrap etc)
>
>		Linus
>  
>
I am truely sorry about my patch being broken by my mail program,
I have tried to fix it now and is trying to resubmit the patch.

From: Kristian Edlund <edlund@groenstue.dk>

I found a few typos, in Documentation/kbuild/modules.txt
I also changes the $PWD to `pwd` for consistency throughout the document.

Signed-off-by: Kristian Edlund <edlund@groenstue.dk>

---

--- modules.txt.orig
+++ modules.txt
@@ -38,8 +38,8 @@
 What is covered within this file is mainly information to authors
 of modules. The author of an external modules should supply
 a makefile that hides most of the complexity so one only has to type
-'make' to buld the module. A complete example will be present in
-chapter ¤. Creating a kbuild file for an external module".
+'make' to build the module. A complete example will be present in
+chapter 4. Creating a kbuild file for an external module".
 
 
 === 2. How to build external modules
@@ -58,8 +58,8 @@
     For the running kernel use:
         make -C /lib/modules/`uname -r`/build M=`pwd`
 
-    For the above command to succeed the kernel must have been built with
-    modules enabled.
+    For the above command to succeed the kernel must have been
+    built with modules enabled.
 
     To install the modules that were just built:
 
@@ -84,14 +84,15 @@
         Same functionality as if no target was specified.
         See description above.
 
-    make -C $KDIR M=$PWD modules_install
+    make -C $KDIR M=`pwd` modules_install
         Install the external module(s).
         Installation default is in /lib/modules/<kernel-version>/extra,
-        but may be prefixed with INSTALL_MOD_PATH - see separate chater.
+        but may be prefixed with INSTALL_MOD_PATH - see
+        separate chapter.
 
-    make -C $KDIR M=$PWD clean
+    make -C $KDIR M=`pwd` clean
         Remove all generated files for the module - the kernel
-        source directory is not moddified.
+        source directory is not modified.
 
     make -C $KDIR M=`pwd` help
         help will list the available target when building external
@@ -99,8 +100,6 @@
 
 --- 2.3 Available options:
 
-    $KDIR refer to path to kernel src
-
     make -C $KDIR
         Used to specify where to find the kernel source.
         '$KDIR' represent the directory where the kernel source is.
@@ -341,7 +340,7 @@
         EXTRA_CFLAGS := -Iinclude
         8123-y := 8123_if.o 8123_pci.o 8123_bin.o
 
-    Note that in the assingment there is no space between -I and the path.
+    Note that in the assignment there is no space between -I and the path.
     This is a kbuild limitation and no space must be present.
 
 


  reply	other threads:[~2005-11-22 22:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-22 13:08 [PATCH] Typos in Documation/kbuild/modules.txt 2.6.15-rc2 Kristian Edlund
2005-11-22 16:56 ` Linus Torvalds
2005-11-22 22:02   ` Kristian Edlund [this message]
2005-11-22 22:08     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43839590.5050409@groenstue.dk \
    --to=edlund@groenstue.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.