From: Giacomo Strangolino <delleceste@gmail.com>
To: netfilter-devel@lists.netfilter.org
Subject: help linked lists and locks
Date: Wed, 23 Nov 2005 12:10:39 +0100 [thread overview]
Message-ID: <43844E2F.5090809@gmail.com> (raw)
Good morning.
In a packet filter which i wrote on my own, i have a linked list of
structures
which i read periodically by means of list_for_each_safe macro.
These structures have a timer, when it expires, the entry is deleted.
The timer can on the other way be updated by mod_timer.
The context of execution is that of a software interrupt (i attach my
code at
netfilter hooks), and some times (after tenths of millions of packets
filtered)
the system goes into panic.
I think i should put some locks when reading in list_for_each or when
deleting an item, or when updating timers.
I thought it was not necessary because of the atomic context.
In fact, should i use read/write_lock? Or spinlocks?
Should i put the locks when reading in list_for_each, when adding an entry
with list_add, when deleting with list_del and also when mod_timer?
I verified that when i put those locks, things go better, but do i need them
so many in my code?
Thanks in advance
Giacomo.
reply other threads:[~2005-11-23 11:10 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43844E2F.5090809@gmail.com \
--to=delleceste@gmail.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.