From: Daniel Drake <dsd@gentoo.org>
To: Jan Panoch <jan@panoch.net>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] PATA support for Intel ICH7 (intel 945G chipset) - 2.6.14.2
Date: Wed, 23 Nov 2005 11:34:33 +0000 [thread overview]
Message-ID: <438453C9.4050200@gentoo.org> (raw)
In-Reply-To: <4383DC5E.3050601@panoch.net>
Jan Panoch wrote:
> Hi,
>
> This patch adds additional Intel ICH7 DID's for Intel chipset 945G to
> the piix driver.
> I need to add PATA support for new intel 945G chipset on Asus
> motherboard P5LD2-VM.
> If acceptable, please apply.
PCI_DEVICE_ID_INTEL_ICH7_2 has been removed in 2.6.15 as it was unused.
Your patch is whitespace damaged (mailer ate the tabs?). You also need to send
it to the linux-ide list and the IDE maintainer (see
Documentation/SubmittingPatches). I don't think it will be accepted because
this hardware is already supported by the ata_piix libata driver.
>
> --- piix.c.orig 2005-11-23 11:46:12.000000000 +0100
> +++ piix.c 2005-11-23 11:13:02.000000000 +0100
> @@ -134,6 +134,7 @@
> case PCI_DEVICE_ID_INTEL_ESB_2:
> case PCI_DEVICE_ID_INTEL_ICH6_19:
> case PCI_DEVICE_ID_INTEL_ICH7_21:
> + case PCI_DEVICE_ID_INTEL_ICH7_2:
> case PCI_DEVICE_ID_INTEL_ESB2_18:
> mode = 3;
> break;
> @@ -448,6 +449,7 @@
> case PCI_DEVICE_ID_INTEL_ESB_2:
> case PCI_DEVICE_ID_INTEL_ICH6_19:
> case PCI_DEVICE_ID_INTEL_ICH7_21:
> + case PCI_DEVICE_ID_INTEL_ICH7_2:
> case PCI_DEVICE_ID_INTEL_ESB2_18:
> {
> unsigned int extra = 0;
> @@ -575,6 +577,7 @@
> /* 21 */ DECLARE_PIIX_DEV("ICH7"),
> /* 22 */ DECLARE_PIIX_DEV("ICH4"),
> /* 23 */ DECLARE_PIIX_DEV("ESB2"),
> + /* 24 */ DECLARE_PIIX_DEV("ICH7"),
> };
>
> /**
> @@ -651,6 +654,7 @@
> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_21, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 21},
> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82801DB_1,
> PCI_ANY_ID, PCI_ANY_ID, 0, 0, 22},
> { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_18, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 23},
> + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_2, PCI_ANY_ID,
> PCI_ANY_ID, 0, 0, 24},
> { 0, },
> };
> MODULE_DEVICE_TABLE(pci, piix_pci_tbl);
>
next prev parent reply other threads:[~2005-11-23 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-23 3:05 [PATCH] PATA support for Intel ICH7 (intel 945G chipset) - 2.6.14.2 Jan Panoch
2005-11-23 11:34 ` Daniel Drake [this message]
2005-11-24 15:09 ` Mark Lord
2005-11-24 16:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438453C9.4050200@gentoo.org \
--to=dsd@gentoo.org \
--cc=jan@panoch.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.