All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>,
	linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet
Date: Wed, 23 Nov 2005 19:14:14 +0300	[thread overview]
Message-ID: <43849556.2000608@ru.mvista.com> (raw)
In-Reply-To: <ACB2F36A-0A37-4EA1-9E4A-F773AD4E0D86@kernel.crashing.org>

Kumar Gala wrote:
> 
> On Nov 23, 2005, at 3:11 AM, Marcelo Tosatti wrote:
> 
>> On Wed, Nov 23, 2005 at 01:40:38PM +1100, Paul Mackerras wrote:
>>> Marcelo Tosatti writes:
>>>
>>>> Paul, you're OK with the following definitions on asm-ppc/io.h?
>>>>
>>>> +/* access ports */
>>>> +#define setbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) 
>>>> |  (_v))
>>>> +#define clrbits32(_addr, _v) out_be32(&(_addr), in_be32(&(_addr)) & 
>>>> ~(_v))
>>>> +
>>>> +#define setbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) 
>>>> |  (_v))
>>>> +#define clrbits16(_addr, _v) out_be16(&(_addr), in_be16(&(_addr)) & 
>>>> ~(_v))
>>>
>>> I guess so... how many drivers need these things?
>>
>> Many.
> 
> Shouldn't these go into some non-arch specific location?  I hate making 
> drivers only build on a give arch.
> 

Hmm, what is the worth? IIRC, in_be* stuff is defined for only ppc-specific 
archs(ppc(64),ppc,powerpc).
> - kumar
> _______________________________________________
> Linuxppc-embedded mailing list
> Linuxppc-embedded@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-embedded
> 
> 


-- 
Sincerely,
Vitaly

  parent reply	other threads:[~2005-11-23 16:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-16 12:04 [PATCH] ppc32: 8xx board-specific platform stuff for fs_enet Vitaly Bordug
2005-11-17 13:58 ` Marcelo Tosatti
2005-11-18 14:09   ` Vitaly Bordug
2005-11-18  9:08     ` Marcelo Tosatti
2005-11-23  2:40       ` Paul Mackerras
2005-11-23  9:11         ` Marcelo Tosatti
2005-11-23 16:05           ` Kumar Gala
2005-11-23 12:00             ` Marcelo Tosatti
2005-11-23 18:25               ` 'Aristeu Sergio Rozanski Filho'
2005-11-23 20:18               ` Dan Malek
2005-11-23 15:39                 ` Marcelo Tosatti
2005-11-30  7:08               ` Kumar Gala
2005-12-01 12:17                 ` Marcelo Tosatti
2005-12-01 14:15                   ` Dan Malek
2005-12-01 15:13                   ` Kumar Gala
2005-11-23 16:14             ` Vitaly Bordug [this message]
2005-11-17 14:07 ` Marcelo Tosatti
2005-11-18 14:11   ` Vitaly Bordug
2005-11-18  9:05     ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2005-11-18 16:19 Vitaly Bordug
2005-11-23  8:34 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43849556.2000608@ru.mvista.com \
    --to=vbordug@ru.mvista.com \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.