From: Eric Dumazet <dada1@cosmosbay.com>
To: Harald Welte <laforge@netfilter.org>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
kaber@trash.net
Subject: Re: Fw: 2.6.15-rc2-mm1 problems (get_cpu / NUMA optimizations)
Date: Thu, 24 Nov 2005 23:11:31 +0100 [thread overview]
Message-ID: <43863A93.2010406@cosmosbay.com> (raw)
In-Reply-To: <20051124205828.GD31478@sunbeam.de.gnumonks.org>
Harald Welte a écrit :
> On Wed, Nov 23, 2005 at 03:56:03PM -0800, David S. Miller wrote:
>
>>I've seen this reported multiple times.
>>
>>It seems that module load is attempted by IP-tables while
>>some locks are held, or similar.
>
>
> yes, this was introduced by the recent NUMA patches that introduced
> get_cpu() / put_cpu() all over the place.
>
>
Hum... I was not aware that disabling preemption (in get_cpu()) had this
effect (ie not allowing to sleep). I was using get_cpu() to bind the thread to
the current cpu, maybe there is something better ?
If not, we can zap get_cpu()/pu_cpu() and use raw_smp_processor_id() as a hint
only, (and dont care of preemption/cpu migration), as the value is only used
as a hint to speedup operations in do_replace(), do_add_counters(),
ipt_unregister_table(), translate_table()...
Eric
next prev parent reply other threads:[~2005-11-24 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051123.155603.64967447.davem@davemloft.net>
2005-11-24 20:58 ` Fw: 2.6.15-rc2-mm1 problems (get_cpu / NUMA optimizations) Harald Welte
2005-11-24 22:11 ` Eric Dumazet [this message]
2005-11-25 2:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43863A93.2010406@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.