From: Pablo Neira Ayuso <pablo@eurodev.net>
To: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Cc: Harald Welte <laforge@netfilter.org>
Subject: [PATCH] [POM-NG] missing spin_unlock_bh in u32 match
Date: Fri, 25 Nov 2005 04:07:13 +0100 [thread overview]
Message-ID: <43867FE1.9050406@eurodev.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 101 bytes --]
Fix missing spin_unlock_bh in exit path in u32. This problem only
affects the 2.6 branch.
--
Pablo
[-- Attachment #2: x --]
[-- Type: text/plain, Size: 608 bytes --]
Index: patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c
===================================================================
--- patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c (revision 4547)
+++ patchlets/u32/linux-2.6/net/ipv4/netfilter/ipt_u32.c (working copy)
@@ -166,8 +166,10 @@
case IPT_U32_AT:
AttPos += val;
pos = number;
- if (AttPos + pos + 3 > skb->len || AttPos + pos < 0)
+ if (AttPos + pos + 3 > skb->len || AttPos + pos < 0) {
+ spin_unlock_bh(&u32_lock);
return 0;
+ }
val = (base[AttPos + pos]<<24)
+(base[AttPos + pos + 1]<<16)
next reply other threads:[~2005-11-25 3:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-25 3:07 Pablo Neira Ayuso [this message]
2005-11-26 23:53 ` [PATCH] [POM-NG] missing spin_unlock_bh in u32 match Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43867FE1.9050406@eurodev.net \
--to=pablo@eurodev.net \
--cc=laforge@netfilter.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.