From: Max Gurtovoy <mgurtovoy@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
Keith Busch <kbusch@kernel.org>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: James Smart <james.smart@broadcom.com>, Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH] nvmet: use a private workqueue instead of the system workqueue
Date: Tue, 22 Mar 2022 14:07:33 +0200 [thread overview]
Message-ID: <43893170-e958-3cdd-e01f-c766126e896a@nvidia.com> (raw)
In-Reply-To: <20220321115727.774650-1-sagi@grimberg.me>
Sagi,
On 3/21/2022 1:57 PM, Sagi Grimberg wrote:
> Any attempt to flush kernel-global WQs has possibility of deadlock
> so we should simply stop using them, instead introduce nvmet_wq
> which is the generic nvmet workqueue for work elements that
> don't explicitly require a dedicated workqueue (by the mere fact
> that they are using the system_wq).
>
> Changes were done using the following replaces:
> s/schedule_work(/queue_work(nvmet_wq, /g
> s/schedule_delayed_work(/queue_delayed_work(nvmet_wq, /g
> s/flush_scheduled_work()/flush_workqueue(nvmet_wq)/g
should we have the same commit for iser Target ?
it uses schedule_delayed_work & flush_scheduled_work as well..
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> ---
> drivers/nvme/target/admin-cmd.c | 2 +-
> drivers/nvme/target/configfs.c | 2 +-
> drivers/nvme/target/core.c | 22 ++++++++++++++++------
> drivers/nvme/target/fc.c | 8 ++++----
> drivers/nvme/target/fcloop.c | 16 ++++++++--------
> drivers/nvme/target/io-cmd-file.c | 6 +++---
> drivers/nvme/target/loop.c | 4 ++--
> drivers/nvme/target/modules.builtin | 0
> drivers/nvme/target/nvmet.h | 1 +
> drivers/nvme/target/passthru.c | 2 +-
> drivers/nvme/target/rdma.c | 12 ++++++------
> drivers/nvme/target/tcp.c | 10 +++++-----
> 12 files changed, 48 insertions(+), 37 deletions(-)
> create mode 100644 drivers/nvme/target/modules.builtin
Looks good,
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
next prev parent reply other threads:[~2022-03-22 12:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 11:57 [PATCH] nvmet: use a private workqueue instead of the system workqueue Sagi Grimberg
2022-03-21 20:41 ` Chaitanya Kulkarni
2022-03-22 11:15 ` Christoph Hellwig
2022-03-22 12:07 ` Max Gurtovoy [this message]
2022-03-23 10:49 ` Sagi Grimberg
2022-03-23 15:30 ` Max Gurtovoy
2022-03-23 8:20 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43893170-e958-3cdd-e01f-c766126e896a@nvidia.com \
--to=mgurtovoy@nvidia.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.