All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: [NETFILTER]: Fix table iteration breakage in {ip6,arp}_tables
Date: Sun, 27 Nov 2005 05:44:06 +0100	[thread overview]
Message-ID: <43893996.9050609@trash.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 49 bytes --]

Another fix for the iptables NUMA optimization.


[-- Attachment #2: x --]
[-- Type: text/plain, Size: 1623 bytes --]

[NETFILTER]: Fix table iteration breakage in {ip6,arp}_tables

Fix breakage from the NUMA optimization, newinfo->entries
is an array now.

Signed-off-by: Patrick McHardy <kaber@trash.net>

---
commit f79000270d87887521fdc81a969b84b709722cfc
tree aa36c4d49ae0fa0397402e7111415f5f18d44302
parent 34166a04163effbc5403dc4017ec00429a320013
author Patrick McHardy <kaber@trash.net> Sun, 27 Nov 2005 05:42:05 +0100
committer Patrick McHardy <kaber@trash.net> Sun, 27 Nov 2005 05:42:05 +0100

 net/ipv4/netfilter/arp_tables.c |    2 +-
 net/ipv6/netfilter/ip6_tables.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/ipv4/netfilter/arp_tables.c b/net/ipv4/netfilter/arp_tables.c
index 54cdb18..bba1563 100644
--- a/net/ipv4/netfilter/arp_tables.c
+++ b/net/ipv4/netfilter/arp_tables.c
@@ -705,7 +705,7 @@ static int translate_table(const char *n
 	i = 0;
 
 	/* Walk through entries, checking offsets. */
-	ret = ARPT_ENTRY_ITERATE(newinfo->entries, newinfo->size,
+	ret = ARPT_ENTRY_ITERATE(entry0, newinfo->size,
 				 check_entry_size_and_hooks,
 				 newinfo,
 				 entry0,
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
index ac1e112..f7b9317 100644
--- a/net/ipv6/netfilter/ip6_tables.c
+++ b/net/ipv6/netfilter/ip6_tables.c
@@ -952,7 +952,7 @@ translate_table(const char *name,
 	duprintf("translate_table: size %u\n", newinfo->size);
 	i = 0;
 	/* Walk through entries, checking offsets. */
-	ret = IP6T_ENTRY_ITERATE(newinfo->entries, newinfo->size,
+	ret = IP6T_ENTRY_ITERATE(entry0, newinfo->size,
 				check_entry_size_and_hooks,
 				newinfo,
 				entry0,

             reply	other threads:[~2005-11-27  4:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-27  4:44 Patrick McHardy [this message]
2005-11-28  4:45 ` [NETFILTER]: Fix table iteration breakage in {ip6,arp}_tables David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43893996.9050609@trash.net \
    --to=kaber@trash.net \
    --cc=davem@davemloft.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.