From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vasily Averin Subject: [SCSI] aic7xxx: reset handler selects a wrong command Date: Sun, 27 Nov 2005 20:15:06 +0300 Message-ID: <4389E99A.8020204@sw.ru> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050405020905090502040004" Return-path: Received: from mailhub.sw.ru ([195.214.233.200]:12162 "EHLO relay.sw.ru") by vger.kernel.org with ESMTP id S1751117AbVK0ROC (ORCPT ); Sun, 27 Nov 2005 12:14:02 -0500 Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: "Justin T. Gibbs" Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, Marcelo Tosatti , Stanislav Protassov This is a multi-part message in MIME format. --------------050405020905090502040004 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Hello Justin To transport scsi reset command to device aic7xxx reset handler looks at the driver's pending_list and searches any proper command. However the search condition has been inverted: ahc_match_scb() returns TRUE if a matched command is found. As a result the reset on required devices did not turn out well, a correctly working neighbour device may be surprised by the reset. aic7xxx reset handler reports about the success, but really the original situation is not corrected yet. The problem has been found first on 2.4 kernels but still it is present in latest 2.6 drivers too. Marcelo, you can use this patch for 2.4 kernel tree. Thank you, Vasily Averin SWSoft Linux Kernel Team [SCSI] aic7xxx: reset handler selects a wrong command To transport scsi reset command to device aic7xxx reset handler looks at the driver's pending_list and searches any proper command. However the search condition has been inverted: ahc_match_scb() returns TRUE if a matched command is found. As a result the reset on required devices did not turn out well, a correctly working neighbour device may be surprised by the reset. aic7xxx reset handler reports about the success, but really the original situation is not corrected yet. Signed-off-by: Vasily Averin --- --------------050405020905090502040004 Content-Type: text/plain; name="diff-drv-aic7xxx-20051127" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diff-drv-aic7xxx-20051127" --- a/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-11-27 18:05:03.000000000 +0300 +++ b/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-11-27 18:06:36.000000000 +0300 @@ -2169,7 +2169,7 @@ ahc_linux_queue_recovery_cmd(struct scsi if (ahc_match_scb(ahc, pending_scb, scmd_id(cmd), scmd_channel(cmd) + 'A', CAM_LUN_WILDCARD, - SCB_LIST_NULL, ROLE_INITIATOR) == 0) + SCB_LIST_NULL, ROLE_INITIATOR)) break; } } --------------050405020905090502040004--