From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Piel Subject: Re: [PATCH 1/2] Move PMBASE reading away and do it only once at initialization time Date: Wed, 30 Nov 2005 12:02:59 +0100 Message-ID: <438D86E3.9070502@lifl.fr> References: <11333087112659-git-send-email-malattia@linux.it> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <11333087112659-git-send-email-malattia@linux.it> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org+glkc-cpufreq=gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="iso-8859-1"; format="flowed" To: Mattia Dongili Cc: CPUFreq Mailing List , Eric Piel , Dominik Brodowski , davej@redhat.com IMHO, this looks very fine :-) 11/30/2005 12:58 AM, Mattia Dongili wrote/a =C3=A9crit: > Signed-off-by: Mattia Dongili >=20 > --- >=20 > arch/i386/kernel/cpu/cpufreq/speedstep-ich.c | 45 ++++++++++++++++++--= ------ > 1 files changed, 32 insertions(+), 13 deletions(-) >=20 > applies-to: 41c86716d1584bad6ddf55c9132ef8b820bc1b15 > 31c370b9ba20188340635fd7cebc150c4b71b097 > diff --git a/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c b/arch/i386/ker= nel/cpu/cpufreq/speedstep-ich.c > index 5b7d18a..17b7864 100644 > --- a/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c > +++ b/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c : > @@ -400,6 +415,10 @@ static int __init speedstep_init(void) > return -EINVAL; > } > =20 > + if (speedstep_find_register()) { > + return -ENODEV; > + } > + Please, keep it simple and do put { and } when there is only one line. > return cpufreq_register_driver(&speedstep_driver); > } > =20