* Re: [PATCH] - ip_conntrack_netlink update.
[not found] <200512011457.jB1EvbA18747@webserver5.arnet.com.ar>
@ 2005-12-01 19:51 ` Pablo Neira Ayuso
2005-12-01 20:05 ` Pablo Neira Ayuso
0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2005-12-01 19:51 UTC (permalink / raw)
To: chentschel; +Cc: netfilter-devel
Hi Christian,
chentschel@arnet.com.ar wrote:
> --- ./ip_conntrack_netlink.c 2005-12-01 11:26:02.275924750 -0300
> +++ /tmp/ip_conntrack_netlink.c 2005-12-01 11:25:49.651135750 -0300
This won't apply with -p1. See that the header must look like:
-- a/net/ipv4/netfilter/ip_conntrack_netlink.c 2005-11-
22 20:18:21.000000000 +0100
+++ b/net/netfilter/nf_conntrack_netlink.c 2005-11-22 20:11
:02.000000000 +0100
> @@ -371,9 +371,12 @@
> goto nfattr_failure;
>
> if (ctnetlink_dump_counters(skb, ct, IP_CT_DIR_ORIGINAL) < 0 ||
> - ctnetlink_dump_counters(skb, ct, IP_CT_DIR_REPLY) < 0)
> - goto nfattr_failure;
> -
> + ctnetlink_dump_counters(skb, ct, IP_CT_DIR_REPLY) < 0 ||
where's the if checking? it's missing. Please compile your changes
before sending them ;)
Please fix it and resend. Thanks!
cheers.
Pablo
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] - ip_conntrack_netlink update.
2005-12-01 19:51 ` [PATCH] - ip_conntrack_netlink update Pablo Neira Ayuso
@ 2005-12-01 20:05 ` Pablo Neira Ayuso
0 siblings, 0 replies; 2+ messages in thread
From: Pablo Neira Ayuso @ 2005-12-01 20:05 UTC (permalink / raw)
To: chentschel; +Cc: netfilter-devel
Pablo Neira Ayuso wrote:
> Hi Christian,
>
> chentschel@arnet.com.ar wrote:
>
>>--- ./ip_conntrack_netlink.c 2005-12-01 11:26:02.275924750 -0300
>>+++ /tmp/ip_conntrack_netlink.c 2005-12-01 11:25:49.651135750 -0300
>
>
> This won't apply with -p1. See that the header must look like:
>
> -- a/net/ipv4/netfilter/ip_conntrack_netlink.c 2005-11-
> 22 20:18:21.000000000 +0100
> +++ b/net/netfilter/nf_conntrack_netlink.c 2005-11-22 20:11
> :02.000000000 +0100
>
>
>>@@ -371,9 +371,12 @@
>> goto nfattr_failure;
>>
>> if (ctnetlink_dump_counters(skb, ct, IP_CT_DIR_ORIGINAL) < 0 ||
>>- ctnetlink_dump_counters(skb, ct, IP_CT_DIR_REPLY) < 0)
>>- goto nfattr_failure;
>>-
>>+ ctnetlink_dump_counters(skb, ct, IP_CT_DIR_REPLY) < 0 ||
>
>
> where's the if checking? it's missing. Please compile your changes
> before sending them ;)
oops, I'm stupid. Sorry, forget about this part, it is OK. I need some
sleep. Please just fix the header and resend. Thanks.
--
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-12-01 20:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200512011457.jB1EvbA18747@webserver5.arnet.com.ar>
2005-12-01 19:51 ` [PATCH] - ip_conntrack_netlink update Pablo Neira Ayuso
2005-12-01 20:05 ` Pablo Neira Ayuso
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.