From: "Jun'ichi Nomura" <j-nomura@ce.jp.nec.com>
To: device-mapper development <dm-devel@redhat.com>,
Christophe Varoqui <christophe.varoqui@free.fr>
Subject: kpartx bug fixes for dos extended partition [2/4]
Date: Thu, 01 Dec 2005 15:14:41 -0500 [thread overview]
Message-ID: <438F59B1.1010901@ce.jp.nec.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
Hi Christophe,
kpartx usually doesn't create a mapping for extended partition.
However, it does if it's empty.
It's harmless but not consistent.
Attached patch makes it consistent by not creating a mapping
even when the extended partition is empty.
Please consider to apply.
If you have logical partitions in extended partition:
# parted /dev/sdc p
Disk geometry for /dev/sdc: 0.000-34686.000 megabytes
Disk label type: msdos
Minor Start End Type Filesystem Flags
1 7.844 31.376 extended
5 7.875 23.532 logical
No mapping is created for extended partition:
# dmsetup table|grep sdc|sort
sdc5: 0 32067 linear 8:32 16128
However, if the extended partition is empty:
# parted /dev/sdc p
Disk geometry for /dev/sdc: 0.000-34686.000 megabytes
Disk label type: msdos
Minor Start End Type Filesystem Flags
1 7.844 31.376 extended
The following mapping is created:
# dmsetup table|grep sdc|sort
sdc1: 0 48195 linear 8:32 16065
Thanks,
Nick
[-- Attachment #2: 02-kpartx-avoid-mapping-empty-extended-part.patch --]
[-- Type: text/x-patch, Size: 516 bytes --]
Don't create mapping for extended partition.
--- multipath-tools.orig/kpartx/dos.c 2005-12-02 01:33:41.000000000 +0900
+++ multipath-tools/kpartx/dos.c 2005-12-02 01:33:29.000000000 +0900
@@ -99,8 +99,11 @@ read_dos_pt(int fd, struct slice all, st
"dos_partition: too many slices\n");
break;
}
- if (is_extended(p.sys_type))
+ if (is_extended(p.sys_type)) {
n += read_extended_partition(fd, &p, sp+n, ns-n);
+ /* hide the extended partition itself */
+ sp[i].size = 0;
+ }
}
return n;
}
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
reply other threads:[~2005-12-01 20:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=438F59B1.1010901@ce.jp.nec.com \
--to=j-nomura@ce.jp.nec.com \
--cc=christophe.varoqui@free.fr \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.