All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Knut Petersen <Knut_Petersen@t-online.de>
Cc: linux-fbdev-devel@lists.sourceforge.net,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: scroll modes
Date: Fri, 02 Dec 2005 07:27:50 +0800	[thread overview]
Message-ID: <438F86F6.9090800@gmail.com> (raw)
In-Reply-To: <438F8136.5030005@t-online.de>

Knut Petersen wrote:
> Hi Geert/Antonino,
> 
 > I have to admit that I´m not one of those gurus who fully understand the
> fbcon
> console layer in all details ... so please check that this does not
> break anything else.
> 

I think I see the problem.  Can you try this instead?

Tony

PS: Do you still need the previous patch?  The one that adjusts
p->vrows?

diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c
index eda237e..587b70e 100644
--- a/drivers/video/fbmem.c
+++ b/drivers/video/fbmem.c
@@ -727,13 +727,18 @@ fb_pan_display(struct fb_info *info, str
 {
         int xoffset = var->xoffset;
         int yoffset = var->yoffset;
-        int err;
+        int err, yres;
 
-        if (!info->fbops->fb_pan_display || xoffset < 0 || yoffset < 0 ||
-	    xoffset + info->var.xres > info->var.xres_virtual ||
-            yoffset + info->var.yres > info->var.yres_virtual)
-                return -EINVAL;
+	if (var->vmode & FB_VMODE_YWRAP)
+		yres = 0;
+	else
+		yres = info->var.yres;
 
+        if (!info->fbops->fb_pan_display || xoffset < 0 || yoffset < 0 ||
+	    var->yoffset + yres > info->var.yres_virtual ||
+	    var->xoffset + info->var.xres > info->var.xres_virtual)
+		return -EINVAL;
+	
 	if ((err = info->fbops->fb_pan_display(var, info)))
 		return err;
 


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click

  parent reply	other threads:[~2005-12-01 23:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-30 12:43 scroll modes Knut Petersen
2005-11-30 12:48 ` Geert Uytterhoeven
2005-11-30 17:32   ` Knut Petersen
2005-11-30 20:40     ` Antonino A. Daplas
2005-11-30 22:54       ` Knut Petersen
2005-12-01  0:01         ` Antonino A. Daplas
2005-12-01 23:03           ` Knut Petersen
2005-12-01 23:16             ` Antonino A. Daplas
2005-12-01 23:27             ` Antonino A. Daplas [this message]
2005-12-01 23:47               ` Knut Petersen
2005-12-02  1:16                 ` Antonino A. Daplas
2005-12-03 12:01                 ` Geert Uytterhoeven
2005-12-02 10:55       ` Knut Petersen
2005-12-08 20:57         ` Antonino A. Daplas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=438F86F6.9090800@gmail.com \
    --to=adaplas@gmail.com \
    --cc=Knut_Petersen@t-online.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.