All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Bordug <vbordug@ru.mvista.com>
To: Alex BASTOS <alebas@televes.com>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: pq2_find_bridges hangs system
Date: Fri, 02 Dec 2005 17:55:09 +0300	[thread overview]
Message-ID: <4390604D.50002@ru.mvista.com> (raw)
In-Reply-To: <1133534967.43905ef73521a@webmail.televes.com:443>

Alex, 
please probe this. If it will not help, pq2ads_setup_pci should be digged for some board specifics.

Also, check if hose->set_cfg_type is 1 as done for ads8272.

-------- Original Message --------
Subject: [patch 01/34] ppc32: Fix incorrect PCI frequency value
Date: Thu, 01 Dec 2005 00:51:15 -0800
From: akpm@osdl.org
To: torvalds@osdl.org
CC: akpm@osdl.org, vbordug@ru.mvista.com, galak@kernel.crashing.org


From: Vitaly Bordug <vbordug@ru.mvista.com>

The time to wait after deasserting PCI_RST has been counted with incorrect
value - this patch fixes the issue.

Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
---

 arch/ppc/syslib/m82xx_pci.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -puN arch/ppc/syslib/m82xx_pci.c~ppc32-fix-incorrect-pci-frequency-value arch/ppc/syslib/m82xx_pci.c
--- devel/arch/ppc/syslib/m82xx_pci.c~ppc32-fix-incorrect-pci-frequency-value	2005-11-30 23:58:00.000000000 -0800
+++ devel-akpm/arch/ppc/syslib/m82xx_pci.c	2005-11-30 23:58:00.000000000 -0800
@@ -248,7 +248,8 @@ pq2ads_setup_pci(struct pci_controller *
 	pci_div = ( (sccr & SCCR_PCI_MODCK) ? 2 : 1) *
 			( ( (sccr & SCCR_PCIDF_MSK) >> SCCR_PCIDF_SHIFT) + 1);
 	freq = (uint)((2*binfo->bi_cpmfreq)/(pci_div));
-	time = (int)666666/freq;
+	time = (int)66666666/freq;
+
 	/* due to PCI Local Bus spec, some devices needs to wait such a long
 	time after RST 	deassertion. More specifically, 0.508s for 66MHz & twice more for 33 */
 	printk("%s: The PCI bus is %d Mhz.\nWaiting %s after deasserting RST...\n",__FILE__,freq,
_



-- 
Sincerely, 
Vitaly

  reply	other threads:[~2005-12-02 14:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-02 10:51 pq2_find_bridges hangs system Alex BASTOS
2005-12-02 10:30 ` Vitaly Bordug
2005-12-02 13:56   ` Alex BASTOS
2005-12-02 14:49     ` Alex BASTOS
2005-12-02 14:55       ` Vitaly Bordug [this message]
2005-12-03 17:36         ` Alex BASTOS
2005-12-13  8:24         ` Alex BASTOS
     [not found]   ` <0IQV004GGIH0UG@mailstore1.hut-mail>
2005-12-02 14:09     ` Kalle Pokki
  -- strict thread matches above, loose matches on Subject: below --
2005-12-14 10:21 Alex BASTOS
2005-12-14 11:29 ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4390604D.50002@ru.mvista.com \
    --to=vbordug@ru.mvista.com \
    --cc=alebas@televes.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.