From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1tFZxE-000584-0V for mharc-qemu-trivial@gnu.org; Mon, 25 Nov 2024 09:20:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFZx7-00056s-EG for qemu-trivial@nongnu.org; Mon, 25 Nov 2024 09:20:38 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tFZx2-0000XC-7O for qemu-trivial@nongnu.org; Mon, 25 Nov 2024 09:20:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732544428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yAVWOFUvVKskdDU+V1zn93YlTAt78Y5f+KZ/cbLa3L0=; b=f1fvkZF1fyCDR73mGPlVL9E9F1ZDxhEj1J4T+98mOGis4G4ZEx7i/191TwN7DaxEWh7Ehv KkIjFqhvcsZK0geX1c9HD/qpnQeQxNleHl04Vk50dk/S7QyN5In6v37hMdDorj4s6UdExw ryIQr3wz2DGvwnyACQJ9TuS/200s2DM= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-JAoFDAADNvOFdhcbfNcyUw-1; Mon, 25 Nov 2024 09:20:25 -0500 X-MC-Unique: JAoFDAADNvOFdhcbfNcyUw-1 X-Mimecast-MFC-AGG-ID: JAoFDAADNvOFdhcbfNcyUw Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7b66c3415feso151469085a.2 for ; Mon, 25 Nov 2024 06:20:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732544425; x=1733149225; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yAVWOFUvVKskdDU+V1zn93YlTAt78Y5f+KZ/cbLa3L0=; b=t2CNIK+R+Cjm0RBhro2eXtIyIwG+vae82gaP7TeQVJBAbDq8ztF25MdJ7g4ZzmTxKF TeHX20k0fJlwgBwkAmjxTGOrSjo+WCVmmc7erUBnhVU8h9h/oNzzwBSZLziLt5L25TC8 3IALtRqhBynktaYGl2vegjXwnS/ovVuFdF4AXk+bh1cA4HXLoVcWYEThEdas+HZZYKN9 sUDcPI07EIiDW4+nq8wDG0xvmMso01i3zA4qKH4Vif4x2oWl2LCOyp/fGfukjl8sQWDE N0jnHJjYkKE6Rdpz57ax89TNhkFbmSGLeulJ12j5eH8Z2U/KjXpkaytGcKqSvEHebylW qC1A== X-Forwarded-Encrypted: i=1; AJvYcCXqtePT9K3G7dbeIiB7e4fgJ7MWXEfVdHPfbPag4ZQNQacbjiIgWtk0fnl5QwltCIy6yXkXZZ8jEwZ9niM=@nongnu.org X-Gm-Message-State: AOJu0YyqJVbk+bQX7zIG7AiG7+8jQNQ6qR5duIi6HQn4rsF9ah7OHvU0 5A54zr1lGc/ddHdBSN18gNoIuU74rl2P/1tBvTyPFge9dbLoLnIkOK2fQRGpNhr9XnLxvXqcQT0 adq7mBzWOXO5Jhnb5DPe6dgcCyc7iV2H/R70bgAtwYWhL982+GAvFOHk= X-Gm-Gg: ASbGncuLdYEktIBdvXxQ5dpDmG+EIWYFbsW+XlN4cq3A6EXwYn4/2aa5EMJd/8/iyV8 BZusNFAtJkEVgGLk8yJ4btwiRxkFX+LGG7sfrSHfWHL/rKrVagqfzCwBn7FvClgGV0pJ7NMkQGH Fzw7lnMfHHjUqKEjhT/LqKk6JrH0unfi6cM6KmyX23o3rnj9YM0K1TUy1kIl1O25Eox+HWMO4vE 6/dG4F8HmQ21zK7PM8Jld3zb4VbHAz/4U59pkP433ZgC1z7wJ8R01uTGAZ5/upxrP1i3LClFNS/ h4o= X-Received: by 2002:a05:620a:25c6:b0:7af:c3f4:ee45 with SMTP id af79cd13be357-7b51459dc5cmr2135748085a.55.1732544424908; Mon, 25 Nov 2024 06:20:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGpb7KbUTr3An8f6rEXKGvDFQeowHrk8wPIo2hsBDaRM3aoo4hzsED1o1zlsaQfsQCU1rYc6w== X-Received: by 2002:a05:620a:25c6:b0:7af:c3f4:ee45 with SMTP id af79cd13be357-7b51459dc5cmr2135741285a.55.1732544424331; Mon, 25 Nov 2024 06:20:24 -0800 (PST) Received: from [192.168.0.7] (ip-109-42-51-70.web.vodafone.de. [109.42.51.70]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b667f71523sm130134085a.0.2024.11.25.06.20.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Nov 2024 06:20:23 -0800 (PST) Message-ID: <43924ccd-61b5-4862-ae54-6c9bfa5e8dda@redhat.com> Date: Mon, 25 Nov 2024 15:20:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH-for-10.0 6/8] hw/riscv/virt: Remove pointless GPEX_HOST() cast To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, QEMU Trivial Cc: Daniel Henrique Barboza , Marcin Juszkiewicz , Bin Meng , Alistair Francis , Harsh Prateek Bora , Zhao Liu , =?UTF-8?Q?Daniel_P_=2E_Berrang=C3=A9?= , Daniel Henrique Barboza , Liu Zhiwei , Palmer Dabbelt , Marcel Apfelbaum , qemu-arm@nongnu.org, "Michael S. Tsirkin" , Nicholas Piggin , Leif Lindholm , Peter Maydell , qemu-riscv@nongnu.org, Weiwei Li , Radoslaw Biernacki , Yanan Wang , Eduardo Habkost , qemu-ppc@nongnu.org References: <20241125140535.4526-1-philmd@linaro.org> <20241125140535.4526-7-philmd@linaro.org> From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20241125140535.4526-7-philmd@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w5OX8QO2bEvj4E_iOnen2Ww5uICzs_m8PoZwVdkqZpo_1732544425 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Nov 2024 14:20:38 -0000 On 25/11/2024 15.05, Philippe Mathieu-Daudé wrote: > No need to QOM-cast twice, since the intermediate value > is not used. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/riscv/virt.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > index 45a8c4f819..2feb851f15 100644 > --- a/hw/riscv/virt.c > +++ b/hw/riscv/virt.c > @@ -1140,23 +1140,21 @@ static inline DeviceState *gpex_pcie_init(MemoryRegion *sys_mem, > dev = qdev_new(TYPE_GPEX_HOST); > > /* Set GPEX object properties for the virt machine */ > - object_property_set_uint(OBJECT(GPEX_HOST(dev)), PCI_HOST_ECAM_BASE, > + object_property_set_uint(OBJECT(dev), PCI_HOST_ECAM_BASE, > ecam_base, NULL); > - object_property_set_int(OBJECT(GPEX_HOST(dev)), PCI_HOST_ECAM_SIZE, > + object_property_set_int(OBJECT(dev), PCI_HOST_ECAM_SIZE, > ecam_size, NULL); > - object_property_set_uint(OBJECT(GPEX_HOST(dev)), > - PCI_HOST_BELOW_4G_MMIO_BASE, > + object_property_set_uint(OBJECT(dev), PCI_HOST_BELOW_4G_MMIO_BASE, > mmio_base, NULL); > - object_property_set_int(OBJECT(GPEX_HOST(dev)), PCI_HOST_BELOW_4G_MMIO_SIZE, > + object_property_set_int(OBJECT(dev), PCI_HOST_BELOW_4G_MMIO_SIZE, > mmio_size, NULL); > - object_property_set_uint(OBJECT(GPEX_HOST(dev)), > - PCI_HOST_ABOVE_4G_MMIO_BASE, > + object_property_set_uint(OBJECT(dev), PCI_HOST_ABOVE_4G_MMIO_BASE, > high_mmio_base, NULL); > - object_property_set_int(OBJECT(GPEX_HOST(dev)), PCI_HOST_ABOVE_4G_MMIO_SIZE, > + object_property_set_int(OBJECT(dev), PCI_HOST_ABOVE_4G_MMIO_SIZE, > high_mmio_size, NULL); > - object_property_set_uint(OBJECT(GPEX_HOST(dev)), PCI_HOST_PIO_BASE, > + object_property_set_uint(OBJECT(dev), PCI_HOST_PIO_BASE, > pio_base, NULL); > - object_property_set_int(OBJECT(GPEX_HOST(dev)), PCI_HOST_PIO_SIZE, > + object_property_set_int(OBJECT(dev), PCI_HOST_PIO_SIZE, > pio_size, NULL); > > sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); > @@ -1189,7 +1187,7 @@ static inline DeviceState *gpex_pcie_init(MemoryRegion *sys_mem, > gpex_set_irq_num(GPEX_HOST(dev), i, PCIE_IRQ + i); > } > > - GPEX_HOST(dev)->gpex_cfg.bus = PCI_HOST_BRIDGE(GPEX_HOST(dev))->bus; > + GPEX_HOST(dev)->gpex_cfg.bus = PCI_HOST_BRIDGE(dev)->bus; > return dev; > } > Reviewed-by: Thomas Huth