From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 7/21] polling loops: change exit condition to
Date: Sun, 04 Dec 2005 10:54:46 +0000 [thread overview]
Message-ID: <4392CAF6.1000807@gmail.com> (raw)
In-Reply-To: <4392357F.30209@gmail.com>
Daniel Marjamäki wrote:
> Patch for: drivers/ieee1394/sbp2.c
>
> Are you sure about this line
> + end_time = jiffies + msecs_to_jiffies(timeout);
>
> To me it seems timeout means nr of jiffies, not milliseconds.
>
> Look at line 1286 in the file for example..
> /* Wait up to 20 seconds */
> if (sbp2util_down_timeout(blabla, 20*HZ)) {
you are right, this line should look like this:
end_time = jiffies + timeout;
regards,
Marcin Slusarz
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-12-04 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-04 0:17 [KJ] [PATCH 7/21] polling loops: change exit condition to Marcin Slusarz
2005-12-04 7:18 ` Daniel Marjamäki
2005-12-04 10:54 ` Marcin Slusarz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4392CAF6.1000807@gmail.com \
--to=marcin.slusarz@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.