From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] CTA_PROTO_NUM is u_int8_t not u_int16_t (was Re: CTA_PROTO_NUM u_int8_t or u_int16_t) Date: Sun, 04 Dec 2005 17:35:03 +0100 Message-ID: <43931AB7.8060400@trash.net> References: <20051124200736.GW31478@sunbeam.de.gnumonks.org> <20051124202125.GX31478@sunbeam.de.gnumonks.org> <43864DC7.6060109@trash.net> <20051125084427.GL31478@sunbeam.de.gnumonks.org> <438710E1.2000202@trash.net> <4387A946.3000005@eurodev.net> <20051129040925.GC3544@rama.towersoft.de> <438CDF45.9040308@trash.net> <4392630F.4040008@eurodev.net> <439313B2.50601@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Harald Welte , Netfilter Development Mailinglist Return-path: To: Pablo Neira Ayuso In-Reply-To: <439313B2.50601@trash.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Patrick McHardy wrote: > Pablo Neira Ayuso wrote: > >> Any update on this? > > > I've added this patch to my queue. It doesn't even affect compatiblity, > userspace can send both u_int8_t or u_int16_t, the binary representation > will look the same. After wakeing up entirely, I noticed this is nonsense, it depends on the byte-order of course. Anyway, I'm going to push this patch forward tonight, it seems libconntrack currently has a number of issues anyway.