Re: [PATCH 2.4] TCP window tracking: nf-log

[Roberto Nibali <ratz@drugphish.ch>]

Hi Willy,

Thanks for your review.

> On Mon, Nov 21, 2005 at 11:15:34AM +0100, Roberto Nibali wrote:
>> Hello,
>>
>> This is the rediffed nf-log patch against 2.4.32, which is needed in
>> order to have the core tcp window tracking patch working in 2.4.x kernels.
> 
> I've fixed two things which prevented it from compiling :
>   - removed a space change in ip_vs_conn.c which might have been caused
>     by a change in your reference 2.4.32 tree ;

Hmm, I hopefully haven't included IPVS stuff into the nf-log patch, have
I? I don't seem to be able to find this change in your proposal.

>   - ip6t_log_target() was not properly renamed as ip6t_log_packet(), so
>     build was broken with IPv6 enabled.

I'll see to it, thanks. As you found out, I've never compiled my patches
with IPv6 selected; thanks for checking it.

> Please use the attached one as an update.

I will, once I get some time again to work on the kernel.

> I'm still in the process of building a new kernel with all this, I'll keep
> you informed.

Excellent.

Have a nice evening,
Roberto Nibali, ratz
-- 
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc