All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Furniss <andy.furniss@dsl.pipex.com>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] tbf and prio blocking some flows entirely
Date: Sun, 04 Dec 2005 22:07:21 +0000	[thread overview]
Message-ID: <43936899.2090007@dsl.pipex.com> (raw)
In-Reply-To: <1133714168.15937.34.camel@pc.local>

Patrick McHardy wrote:
> Brian J. Murrell wrote:
> 
>> I thought I had this all worked out, but it seems not.  The following tc
>> configuration:
>>
>> tc qdisc del dev ppp0 root 2> /dev/null > /dev/null
>> tc qdisc add dev ppp0 root handle 1: tbf rate 120kbit burst 1200 limit 1
> 
> 
>> But it seems that some outbound flows are being blocked entirely.  I
>> don't think they are being starved though.  Even if they end up in 2:3,
>> they should at least be treated fairly.  But I am producing a flow to
>> 66.1.2.3 which does increment the counters in 2:1 but after a few
>> packets the flow stalls:
> 
> 
> Your burst is too small. It needs to be at least one MTU.

Patrick do you know why prio is requeueing here?

I see the same testing with (a fixed) Brian's setup. If it's to get 
length then it's going to be a bit out sometimes with sfq attached - it 
will also messup sfq fairness whatever the reason.

Brian - limit is in bytes though you get away with it here by adding 
prio/sfq, limit 1 would stop traffic if tbf was alone. Also if you ever 
try tbf on ethX then burst/mtu/limit need to be your mtu + 14.

SFQ causes packet reordering when it perturbs and is best for bulk 
traffic. I would put a shortish bfifo on interactive class (though in 
practice you've kindof lost the battle if your interactive has queued, 
so its sfq should be empty when a packet arrives anyway).

Andy.
_______________________________________________
LARTC mailing list
LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/cgi-bin/mailman/listinfo/lartc

  parent reply	other threads:[~2005-12-04 22:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-04 16:36 [LARTC] tbf and prio blocking some flows entirely Brian J. Murrell
2005-12-04 16:54 ` Andreas Klauer
2005-12-04 18:17 ` Brian J. Murrell
2005-12-04 18:46 ` Patrick McHardy
2005-12-04 18:56 ` Andreas Klauer
2005-12-04 22:07 ` Andy Furniss [this message]
2005-12-04 22:50 ` Brian J. Murrell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43936899.2090007@dsl.pipex.com \
    --to=andy.furniss@dsl.pipex.com \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.