All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@eurodev.net>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@lists.netfilter.org,
	"David S.Miller" <davem@davemloft.net>
Subject: Re: [NETFILTER 6/9]: Mark ctnetlink as EXPERIMENTAL
Date: Mon, 05 Dec 2005 11:06:45 +0100	[thread overview]
Message-ID: <43941135.2060300@eurodev.net> (raw)
In-Reply-To: <20051204210123.24032.2569.sendpatchset@localhost.localdomain>

Hi Patrick,

Patrick McHardy wrote:
> [NETFILTER]: Mark ctnetlink as EXPERIMENTAL
> 
> Should have been marked EXPERIMENTAL from the beginning, as the current
> bunch of fixes show.
> 
> diff --git a/net/ipv4/netfilter/Kconfig b/net/ipv4/netfilter/Kconfig
> index 0bc0052..88a6065 100644
> --- a/net/ipv4/netfilter/Kconfig
> +++ b/net/ipv4/netfilter/Kconfig
> @@ -56,8 +56,8 @@ config IP_NF_CONNTRACK_MARK
>  	  instead of the individual packets.
>  	
>  config IP_NF_CONNTRACK_EVENTS
> -	bool "Connection tracking events"
> -	depends on IP_NF_CONNTRACK
> +	bool "Connection tracking events (EXPERIMENTAL)"
> +	depends on EXPERIMENTAL && IP_NF_CONNTRACK

The patch is imcomplete, NF_CONNTRACK_EVENTS must be set as EXPERIMENTAL
as well (see net/netfilter/Kconfig).

-- 
Pablo

  reply	other threads:[~2005-12-05 10:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-04 21:01 [NETFILTER 0/9]: Netfilter fixes Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 1/9]: nf_conntrack: Fix missing check for ICMPv6 type Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 2/9]: nfnetlink: Fix calculation of minimum message length Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 3/9]: Fix incorrect argument to ip_nat_initialized() in ctnetlink Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 4/9]: Fix ip_conntrack_flush abuse " Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 5/9]: Fix CTA_PROTO_NUM attribute size " Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 6/9]: Mark ctnetlink as EXPERIMENTAL Patrick McHardy
2005-12-05 10:06   ` Pablo Neira Ayuso [this message]
2005-12-05 15:26     ` Patrick McHardy
2005-12-05 21:38       ` David S. Miller
2005-12-04 21:01 ` [NETFILTER 7/9]: Wait for untracked references in nf_conntrack module unload Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 8/9]: Fix unbalanced read_unlock_bh in ctnetlink Patrick McHardy
2005-12-04 21:01 ` [NETFILTER 9/9]: Don't use conntrack entry after dropping the reference Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43941135.2060300@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.