All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Slusarz <marcin.slusarz@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH 1/21] polling loops: change exit condition
Date: Mon, 05 Dec 2005 17:12:59 +0000	[thread overview]
Message-ID: <4394751B.3080701@gmail.com> (raw)
In-Reply-To: <43923469.3090808@gmail.com>

Nishanth Aravamudan wrote:
>>>here is the first part of patch which changes many polling loops to use
>>>jiffies and time_after / time_before instead of counters
>>>most of the changes are in drivers directory (except first patch)
>>>as it is my first patch for linux kernel, feel free to point out any
>>>mistake you'll find
>>
>>Hmm, what happened to the poll_event API that Nish had suggested
>>some time ago for this problem? Was there an actual reason against
>>merging it or did the patch just get lost?
> 
> 
> A good question. I'll try to dig up my patch from my old machine and
> take a look if it can be used instead of all these changes.
i think you ment "with", not "instead" ;)
in my ("kernel newbie" ;) humble opinion these macros make code harder
too read

(last version of your patch i found is here: 
http://lists.osdl.org/pipermail/kernel-janitors/2005-March/003699.html)

regards,
Marcin
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-12-05 17:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-04  0:12 [KJ] [PATCH 1/21] polling loops: change exit condition to Marcin Slusarz
2005-12-04 19:57 ` Arnd Bergmann
2005-12-04 20:18 ` Nishanth Aravamudan
2005-12-05 17:12 ` Marcin Slusarz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4394751B.3080701@gmail.com \
    --to=marcin.slusarz@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.