Re: [KJ] rfc: print mac addr

[walter harms <wharms@bfs.de>]

Paolo Teti wrote:
> Hi walter
> 
>> for (i = 0; i < 6; i++)
>>    printk("%2.2x%c", dev->dev_addr[i],i = 5 ? '\n' : ':');
>>
> 
> 1. Please post an example or the file name!

cd linux/drivers/net
grep dev_addr *.c | grep printk


> 
> 2. Are you sure that this portion of code isn't into a DEBUG block
> (something like #ifdef DEBUG_xx)?

i did not check every file but looked into a few and the pattern is all 
the same. maybe some of them are inside a #ifdef debug the few i looked 
are not.

i know gregKH added a few dev helper macros but i can not find them 
anymore. The idea is to provide a function like:

void print_mac(struct net_device *dev)
{
    int i;
    printk(KERN_INFO);
    for (i = 0; i < MAX_ADDR_LEN; i++)
         printk("%2.2x%c", dev->dev_addr[i],i = (MAX_ADDR_LEN-1) ? '\n' 
: ':');

}
may you like to return a string ?

re,
  walter



_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors