From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Ling, Xiaofeng" <xiaofeng.ling@intel.com>
Subject: [PATCH]Don't unshadow current used shadow L2 table.
Date: Thu, 08 Dec 2005 16:02:42 +0800
Message-ID: <4397E8A2.20307@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="------------010503050100050009080007"
Return-path: <xen-devel-bounces@lists.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

This is a multi-part message in MIME format.
--------------010503050100050009080007
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

# HG changeset patch
# User Xiaofeng Ling <xiaofeng.ling@intel.com>
# Node ID cc6e19224d0b755d24358cd15d1a40f894d320b4
# Parent  b215584242c43415eccd008b90c812f3d04b398d
Don't unshadow when the shadow l2 is the current used shadow table.
Otherwise, when destorying the domain, if the current sl2 is unpinned,
the shadow page will be freed without accquire the shadow_lock.
This may also improve the performance due to avoiding uncessary
unshadow.

Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com>

--------------010503050100050009080007
Content-Type: text/x-patch;
 name="unshadow-fix.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="unshadow-fix.patch"

# HG changeset patch
# User Xiaofeng Ling <xiaofeng.ling@intel.com>
# Node ID cc6e19224d0b755d24358cd15d1a40f894d320b4
# Parent  b215584242c43415eccd008b90c812f3d04b398d
Don't unshadow when the shadow l2 is the current used shadow table.
Otherwise, when destory the domain, if the current sl2 is unpinned,
the shadow page will be freed without accquire the shadow_lock.
This may also improve the performance due to avoiding uncessary
unshadow.

Signed-off-by: Xiaofeng Ling <xiaofeng.ling@intel.com>

diff -r b215584242c4 xen/arch/x86/shadow.c
--- a/xen/arch/x86/shadow.c	Wed Dec  7 16:26:07 2005 +0000
+++ b/xen/arch/x86/shadow.c	Thu Dec  8 15:07:52 2005 +0800
@@ -1450,6 +1450,7 @@
     int changed;
     u32 min_max_shadow, min_max_snapshot;
     int min_shadow, max_shadow, min_snapshot, max_snapshot;
+    struct vcpu *v;
 
     ASSERT(shadow_lock_is_acquired(d));
 
@@ -1739,6 +1740,9 @@
 
         if ( unlikely(unshadow) )
         {
+            for_each_vcpu(d, v)
+                if(smfn == pagetable_get_pfn(v->arch.shadow_table))
+                    return need_flush;
             perfc_incrc(unshadow_l2_count);
             shadow_unpin(smfn);
 #if CONFIG_PAGING_LEVELS == 2
diff -r b215584242c4 xen/arch/x86/shadow32.c
--- a/xen/arch/x86/shadow32.c	Wed Dec  7 16:26:07 2005 +0000
+++ b/xen/arch/x86/shadow32.c	Thu Dec  8 15:07:52 2005 +0800
@@ -2326,6 +2326,7 @@
     int changed;
     u32 min_max_shadow, min_max_snapshot;
     int min_shadow, max_shadow, min_snapshot, max_snapshot;
+    struct vcpu *v;
 
     ASSERT(shadow_lock_is_acquired(d));
 
@@ -2527,6 +2528,9 @@
 
         if ( unlikely(unshadow) )
         {
+            for_each_vcpu(d, v)
+                if(smfn == pagetable_get_pfn(v->arch.shadow_table))
+                    return need_flush;
             perfc_incrc(unshadow_l2_count);
             shadow_unpin(smfn);
             if ( unlikely(shadow_mode_external(d)) )

--------------010503050100050009080007
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--------------010503050100050009080007--