From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Long Li <longli@microsoft.com>
Cc: dev@dpdk.org, matan@nvidia.com,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Ray Kinsella <mdr@ashroe.eu>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable
Date: Thu, 28 Oct 2021 12:38:32 +0200 [thread overview]
Message-ID: <4398364.iK1UikUNes@thomas> (raw)
In-Reply-To: <1628c943-58b6-12ff-9827-dc493420e074@intel.com>
28/10/2021 12:22, Ferruh Yigit:
> On 10/28/2021 9:34 AM, Thomas Monjalon wrote:
> > The port ownership concept was introduced in ethdev in DPDK 18.02.
> > Not sure it is used by applications except those using failsafe or netvsc.
> > It can also be used by libraries or applications to sort out
> > how ports are controlled.
> >
> > Hiding sub-ports controlled by failsafe or netvsc look to be enough
> > justification to promote this API as stable.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> There is a defect in the 'rte_eth_dev_owner_delete()', which cause a crash,
> it is fixed in my ethdev unit test patch:
> https://patches.dpdk.org/project/dpdk/patch/20210716142800.3853651-8-ferruh.yigit@intel.com/
>
> I think we should get the fix first.
I think such fix should be sent separately.
OK to get the fix first.
> And the crash not detected/reported until now makes me think API is still
> not used much, I wonder if we should wait a little more to mature them.
It is not a surprise that the delete operation is not used much.
But the set operation is used.
I am not sure about waiting more. I have no strong opinion.
> Also only internal user of the API is 'drivers/net/netvsc', I wonder if
> PMD detect the crash?
Question for Long Li?
prev parent reply other threads:[~2021-10-28 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 8:34 [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable Thomas Monjalon
2021-10-28 8:37 ` Kinsella, Ray
2021-10-28 8:55 ` Andrew Rybchenko
2022-06-02 11:43 ` Ferruh Yigit
2021-10-28 10:22 ` Ferruh Yigit
2021-10-28 10:38 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4398364.iK1UikUNes@thomas \
--to=thomas@monjalon.net \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=longli@microsoft.com \
--cc=matan@nvidia.com \
--cc=mdr@ashroe.eu \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.