All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Xiao Ni <xni@redhat.com>, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/1] md/raid10: Remove rcu_dereference when it doesn't need rcu lock to protect
Date: Mon, 16 Aug 2021 17:33:00 +0800	[thread overview]
Message-ID: <4398469c-571e-ae00-99df-6e46d2edb3a7@linux.dev> (raw)
In-Reply-To: <CALTww2-YhNyKCyMjjviWJ4XmELNUZJonryrJfXtrwP4DU-C1zg@mail.gmail.com>

Hi Xiao,

On 8/16/21 5:01 PM, Xiao Ni wrote:
> On Mon, Aug 16, 2021 at 2:36 PM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>> Can rdev be removed between the first loop and the second loop?
>>
> Hi Guoqing
>
> As the patch's commit message says, it adds rdev->nr_pending already.
> So we can guarantee the rdev
> can't be removed during the first loop and the second loop.

I missed that, thanks for clarification. Maybe mention it in description 
that  nr_pending is incremented
which means rdev can't disappear.

Thanks,
Guoqing

  parent reply	other threads:[~2021-08-16  9:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-09  4:01 [PATCH 1/1] md/raid10: Remove rcu_dereference when it doesn't need rcu lock to protect Xiao Ni
2021-08-13 16:49 ` Song Liu
2021-08-14  1:34   ` Xiao Ni
2021-08-16  5:22     ` Song Liu
2021-08-16  8:58       ` Xiao Ni
2021-08-16  6:35 ` Guoqing Jiang
     [not found]   ` <CALTww2-YhNyKCyMjjviWJ4XmELNUZJonryrJfXtrwP4DU-C1zg@mail.gmail.com>
2021-08-16  9:33     ` Guoqing Jiang [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-08-18  1:36 Xiao Ni
2021-08-18  1:43 ` Guoqing Jiang
2021-08-18  1:55   ` Xiao Ni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4398469c-571e-ae00-99df-6e46d2edb3a7@linux.dev \
    --to=guoqing.jiang@linux.dev \
    --cc=linux-raid@vger.kernel.org \
    --cc=xni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.