From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 3/3] Some "make check" tests for xen/common Date: Fri, 09 Dec 2005 09:52:42 -0600 Message-ID: <4399A84A.4010104@us.ibm.com> References: <20051209055625.GU25348@bakeyournoodle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20051209055625.GU25348@bakeyournoodle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Tony Breeds Cc: Xen-Devel List-Id: xen-devel@lists.xenproject.org Hi Tony, I've been trying out the make check/fullcheck and I'm very impressed! I hope it gets pulled into the tree soon. Two suggestions though, for patches this large, it would help to either attach it to the original mail or provide a url to it. inlining is nice for review but a pain to pull out and apply to a tree. Also, with the latest unstable (8311:53cff3f88e45) the patches fail to build (on xen/common/test/test_event_channel.c) because it cannot find the include file in the #include "../event_channel.c". I was able to work around this by adding -I../../include to the build rule in the Makefile. Otherwise, this stuff rocks! Regards, Anthony Liguori Tony Breeds wrote: >Signed-off-by: Tony Breeds > >----- Forwarded message from Rusty Russell ----- > >To: Tony Breeds >From: Rusty Russell >Subject: [PATCH 3/3] Some "make check" tests for xen/common >Date: Fri, 09 Dec 2005 16:47:43 +1100 > >Some of these tests could probably be improved, but this is a first cut. >Not all the files are tested yet, just enough to know we're on the right >track. > >Signed-off-by: Rusty Russell > >