All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <kiszka@domain.hid>
To: Philippe Gerum <rpm@xenomai.org>
Cc: xenomai-core <xenomai@xenomai.org>
Subject: Re: [Xenomai-core] [patch] fix rt_task_delete for cancellable    rt-threads
Date: Sat, 10 Dec 2005 15:52:21 +0100	[thread overview]
Message-ID: <439AEBA5.1090502@domain.hid> (raw)
In-Reply-To: <4399E194.6020403@domain.hid>


[-- Attachment #1.1: Type: text/plain, Size: 224 bytes --]

Hi Philippe,

really hope we can close this issue soon, but I managed to add another
regression with my fix (rt_task_delete(NULL) caused seg-faults, e.g. in
latency). Please apply the attached path against current SVN.

Jan

[-- Attachment #1.2: rt_task_delete.patch.fix --]
[-- Type: text/plain, Size: 494 bytes --]

Index: src/skins/native/task.c
===================================================================
--- src/skins/native/task.c	(Revision 251)
+++ src/skins/native/task.c	(Arbeitskopie)
@@ -206,9 +206,11 @@
 {
     int err;
 
-    err = pthread_cancel((pthread_t)task->opaque2)
-    if (err)
-        return -err;
+    if (task) {
+	err = pthread_cancel((pthread_t)task->opaque2);
+	if (err)
+	    return -err;
+    }
 
     err = XENOMAI_SKINCALL1(__native_muxid,
 			    __native_task_delete,

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]

      reply	other threads:[~2005-12-10 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-08 18:42 [Xenomai-core] [patch] fix rt_task_delete for cancellable rt-threads Jan Kiszka
2005-12-09 19:57 ` Jan Kiszka
2005-12-10 14:52   ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439AEBA5.1090502@domain.hid \
    --to=kiszka@domain.hid \
    --cc=rpm@xenomai.org \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.