All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
Cc: Harald Welte <laforge@netfilter.org>,
	netfilter-devel@lists.netfilter.org
Subject: Re: [1/1] OSF: netlink related changes.
Date: Mon, 12 Dec 2005 08:20:22 +0100	[thread overview]
Message-ID: <439D24B6.6080504@trash.net> (raw)
In-Reply-To: <20051209210220.GA28195@2ka.mipt.ru>

Evgeniy Polyakov wrote:
> This patch has been done against just downloaded ipt_osf.c file from
> cvs.netfilter.org.
> I only read list archive and did not receive your feedback, sorry for
> not answering.

Well it still didn't apply. I finally fixed it up manually, but the
reason is that there is no such line "nts->netlink_kernel_create"
in SVN, and I don't see how this ever could have compiled, since
nts is a struct sock, which doesn't have a netlink_kernel_create
member. I also noticed that you're reusing NETLINK_NFLOG. You can't
do that. We can reserve a nfnetlink group if you need.

> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,14)
>  	nts->netlink_kernel_create(NETLINK_NFLOG, NULL);
> +#else
> +	nts->netlink_kernel_create(NETLINK_NFLOG, 1, NULL, THIS_MODULE);
> +#endif
>  	if (!nts) {
>  		log("netlink_kernel_create() failed\n");
>  	}
> 
> 

  reply	other threads:[~2005-12-12  7:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-09 21:02 [1/1] OSF: netlink related changes Evgeniy Polyakov
2005-12-12  7:20 ` Patrick McHardy [this message]
2005-12-12 12:06 ` Evgeniy Polyakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439D24B6.6080504@trash.net \
    --to=kaber@trash.net \
    --cc=johnpol@2ka.mipt.ru \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.