From: Martin Peschke <mp3@de.ibm.com>
To: Matthew Wilcox <matthew@wil.cx>, Andreas Herrmann <AHERRMAN@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, linux-scsi@vger.kernel.org
Subject: Re: [patch 6/6] statistics infrastructure - exploitation: zfcp
Date: Wed, 14 Dec 2005 17:55:15 +0100 [thread overview]
Message-ID: <43A04E73.2020808@de.ibm.com> (raw)
In-Reply-To: <20051214162437.GW9286@parisc-linux.org>
Matthew Wilcox wrote:
> On Wed, Dec 14, 2005 at 05:14:30PM +0100, Martin Peschke wrote:
>
>> if (device_register(&unit->sysfs_device)) {
>>+ zfcp_unit_statistic_unregister(unit);
>> kfree(unit);
>> return NULL;
>> }
>>
>> if (zfcp_sysfs_unit_create_files(&unit->sysfs_device)) {
>>+ zfcp_unit_statistic_unregister(unit);
>> device_unregister(&unit->sysfs_device);
>> return NULL;
>> }
>
>
> Unrelated, but doesn't that error path forget to release unit?
>
>
correct, I guess ... Andreas, could you fix this?
next prev parent reply other threads:[~2005-12-14 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 16:14 [patch 6/6] statistics infrastructure - exploitation: zfcp Martin Peschke
2005-12-14 16:24 ` Matthew Wilcox
2005-12-14 16:55 ` Martin Peschke [this message]
2005-12-14 17:17 ` Heiko Carstens
2005-12-14 16:59 ` Christoph Hellwig
2005-12-15 3:54 ` Martin Peschke
2005-12-15 7:37 ` Arjan van de Ven
2005-12-15 11:23 ` Martin Peschke
2005-12-15 11:46 ` Arjan van de Ven
2005-12-15 14:38 ` Martin Peschke
-- strict thread matches above, loose matches on Subject: below --
2005-12-15 15:27 James.Smart
2005-12-15 15:27 ` James.Smart
2005-12-15 17:47 ` Martin Peschke
2005-12-31 6:55 ` Marcelo Tosatti
2006-05-19 16:14 [Patch " Martin Peschke
2006-05-24 12:35 Martin Peschke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A04E73.2020808@de.ibm.com \
--to=mp3@de.ibm.com \
--cc=AHERRMAN@de.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.