Reiser4 Pseudo Directory Segfault

Reiser4 Pseudo Directory Segfault

[Peter van Hardenberg]

How to produce the error:

$ chmod +w "file/...."
$ touch file/..../newattr
Segmentation fault.

We tried setting "dir_eperm" on the pseudo directory plugin's create member. 
Why didn't this fix it?

-pvh

-- 
Peter van Hardenberg (pvh@pvh.ca)
Victoria, BC, Canada

Re: Reiser4 Pseudo Directory Segfault

[Edward Shishkin]

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]

Peter van Hardenberg wrote:

>How to produce the error:
>
>$ chmod +w "file/...."
>$ touch file/..../newattr
>Segmentation fault.
>  
>

What the basic setup (kernel, patches) do you use?
Indeed, in the old one the problem exists, because init_pseudo()
does not care about missed regular plugin, so the attached patch
fixes the problem.

Thanks,
Edward.

>We tried setting "dir_eperm" on the pseudo directory plugin's create member. 
>Why didn't this fix it?
>
>-pvh
>
>  
>


[-- Attachment #2: create_pseudo_fix.diff --]
[-- Type: text/x-diff, Size: 347 bytes --]

--- inode_ops.c~	2005-10-06 21:54:52.000000000 +0400
+++ inode_ops.c	2005-12-15 21:56:55.927839866 +0300
@@ -90,6 +90,8 @@
 
 	memset(&data, 0, sizeof data);
 	data.mode = S_IFREG | mode;
+	if (!inode_regular_plugin(parent))
+		return -EINVAL;
 	data.id = inode_regular_plugin(parent)->id;
 	return invoke_create_method(parent, dentry, &data);
 }

Re: Reiser4 Pseudo Directory Segfault

[Peter van Hardenberg]

Edward,

we are running reiser4-for-2.6.12-3.patch.gz on 2.6.12 Debian. Your patch 
worked perfectly and directed us to some code that answered a few other 
questions we had. Thank you.

-pvh

On December 15, 2005 11:33 am, Edward Shishkin wrote:
> Peter van Hardenberg wrote:
> >How to produce the error:
> >
> >$ chmod +w "file/...."
> >$ touch file/..../newattr
> >Segmentation fault.
>
> What the basic setup (kernel, patches) do you use?
> Indeed, in the old one the problem exists, because init_pseudo()
> does not care about missed regular plugin, so the attached patch
> fixes the problem.
>
> Thanks,
> Edward.
>
> >We tried setting "dir_eperm" on the pseudo directory plugin's create
> > member. Why didn't this fix it?
> >
> >-pvh

-- 
Peter van Hardenberg (pvh@pvh.ca)
Victoria, BC, Canada