From: Marco Costalba <mcostalba@gmail.com>
To: Fredrik Kuivinen <freku045@student.liu.se>
Cc: Timo Hirvonen <tihirvon@gmail.com>,
Junio C Hamano <junkio@cox.net>,
git@vger.kernel.org
Subject: Re: [PATCH 5/11] git-applypatch: Usage string clean-up, emit usage string at incorrect invocation
Date: Thu, 15 Dec 2005 21:30:03 +0100 [thread overview]
Message-ID: <43A1D24B.5070603@gmail.com> (raw)
In-Reply-To: <20051215195528.GA14388@c165.ib.student.liu.se>
Fredrik Kuivinen wrote:
> On Wed, Dec 14, 2005 at 02:45:42PM +0200, Timo Hirvonen wrote:
>
>>On Tue, 13 Dec 2005 21:20:57 -0800
>>Junio C Hamano <junkio@cox.net> wrote:
>>
>>
>>>freku045@student.liu.se writes:
>>>
>>>
>>>> . git-sh-setup
>>>>
>>>>+[[ "$#" = "3" || "$#" = "4" ]] || usage
>>>>+
>>>
>>>I do not see much advantage to use [[...]] construct here.
>>
>>[[ ]] is bashishm. Does not work with ash.
>>
>>
>>test $# -ge 3 && test $# -le 4 || usage
>>
>>You don't need to quote $# because it is always defined (and always
>>non-negative integer). You can't unset or set it.
>
>
This patch seems not working for me:
$ git-applymbox -k 0001-JUST-A-TEST.txt
1 patch(es) to process.
Usage: /home/marco/bin/git-applypatch <msg> <patch> <info> [<signoff>]
where
$ cat 0001-JUST-A-TEST.txt
From nobody Mon Sep 17 00:00:00 2001
Subject: [PATCH] JUST A TEST
From: Marco Costalba <mcostalba@gmail.com>
Date: 1134677832 +0100
---
git-applypatch.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
ee8ea125fd2b0598e26e1556210abb9d0edc459a
diff --git a/git-applypatch.sh b/git-applypatch.sh
index e8ba34a..26b4cba 100755
--- a/git-applypatch.sh
+++ b/git-applypatch.sh
@@ -10,7 +10,7 @@
## $3 - "info" file with Author, email and subject
## $4 - optional file containing signoff to add
##
-
+## JUST A TEST
USAGE='<msg> <patch> <info> [<signoff>]'
. git-sh-setup
--
0.99.9.GIT
The offending patch is
Author: Junio C Hamano <junkio@cox.net>
Date: 14/12/2005 03:19:12
Parent: git-repack: Usage string clean-up, emit usage at incorrec...
applypatch: no need to do non-portable [[ ... ]]
... when old, proven, case would do.
Signed-off-by: Junio C Hamano <junkio@cox.net>
--- a/git-applypatch.sh
+++ b/git-applypatch.sh
@@ -14,7 +14,7 @@
USAGE='<msg> <patch> <info> [<signoff>]'
. git-sh-setup
-[[ "$#" = "3" || "$#" = "4" ]] || usage
+case "$#" in 3|4) usage ;; esac
final=.dotest/final-commit
##
reverting the patch everything works fine.
Marco
next prev parent reply other threads:[~2005-12-15 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 22:30 [PATCH 0/11] Usage string clean-up freku045
2005-12-13 22:30 ` [PATCH 3/11] git-revert: " freku045
2005-12-13 22:30 ` [PATCH 7/11] git-fetch: Usage string clean-up, emit usage string at unrecognized option freku045
2005-12-13 22:30 ` [PATCH 1/11] Trivial usage string clean-up freku045
2005-12-13 22:30 ` [PATCH 5/11] git-applypatch: Usage string clean-up, emit usage string at incorrect invocation freku045
2005-12-14 5:20 ` Junio C Hamano
2005-12-14 12:45 ` Timo Hirvonen
2005-12-15 19:55 ` Fredrik Kuivinen
2005-12-15 20:30 ` Marco Costalba [this message]
2005-12-15 20:42 ` Junio C Hamano
2005-12-13 22:30 ` [PATCH 2/11] git-verify-tag: " freku045
2005-12-13 22:30 ` [PATCH 4/11] git-am: Usage string clean-up freku045
2005-12-13 22:30 ` [PATCH 8/11] git-lost-found: Usage string clean-up, emit usage string at incorrect invocation freku045
2005-12-13 22:30 ` [PATCH 6/11] git-cherry: Usage string clean-up, use the 'usage' function freku045
2005-12-13 22:30 ` [PATCH 9/11] git-prune: " freku045
2005-12-13 22:30 ` [PATCH 11/11] git-repack: Usage string clean-up, emit usage at incorrect invocation freku045
2005-12-13 22:30 ` [PATCH 10/11] git-rebase: Usage string clean-up, emit usage string " freku045
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A1D24B.5070603@gmail.com \
--to=mcostalba@gmail.com \
--cc=freku045@student.liu.se \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=tihirvon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.