Re: [KJ] RFC: New todo for loops

[walter harms <wharms@bfs.de>]

Hi daniel,
  i do not like the idea. the code is harder to read and debug, smashing 
pointers is easy done. i would not trade that for speed.

SFIK, array[i] is read as *(array+i) with c-compilers. nice example is 
in "how to write unmaintainable code".


re,
  walter


Daniel Marjamäki wrote:
> Hello friends!
> 
> I have a suggestion for the TODO.
> Making loops faster is important. Therefore in the loops we should use pointers instead of arrays.
> 
> Example (fs/reiser/file.c:268):
> 	int i;
> 	for (i = 0; i < blocks_to_allocate; i++)
> 		allocated_blocks[i] = cpu_to_le32(allocated_blocks[i]);
> 
> This could be changed to something like:
> 	struct b_blocknr_t *block, *block_last;
> 	block_last = &allocated_blocks[allocated_blocks-1];
> 	for (block = allocated_blocks; block <= block_last; block++)
> 			*block = cpu_to_le32(*block);
> 
> Best Regards,
> Daniel Marjamäki
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
> 
> 
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors