From: Patrick McHardy <kaber@trash.net>
To: Phil Oester <kernel@linuxace.com>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH] pptp conntrack broken when non-modular
Date: Mon, 19 Dec 2005 10:28:19 +0100 [thread overview]
Message-ID: <43A67D33.70005@trash.net> (raw)
In-Reply-To: <20051218194848.GA1038@linuxace.com>
Phil Oester wrote:
> The GRE protocol helper of PPTP does not get properly registered
> when it is built in, because ip_nat_proto_gre_init runs prior to
> ip_nat_init, so ip_nat_protos is unitialized when ip_nat_proto_gre_init
> tries to register protocol 47.
>
> Changing ip_nat_protocol_register to unconditionally register solves
> half the problem. But then when ip_nat_init does run, it overwrites
> the registration with ip_nat_unknown_protocol. So the second
> part of the fix is to change ip_nat_init not to overwrite previously
> registered protos.
I think the correct fix is to change the initialisation order so
the NAT core comes before protocol helpers. I'm going to look into
this.
next prev parent reply other threads:[~2005-12-19 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-18 19:48 [PATCH] pptp conntrack broken when non-modular Phil Oester
2005-12-19 9:28 ` Patrick McHardy [this message]
2005-12-19 10:18 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A67D33.70005@trash.net \
--to=kaber@trash.net \
--cc=kernel@linuxace.com \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.