From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Junio C Hamano <junkio@cox.net>, git@vger.kernel.org
Subject: Re: EAGAIN?
Date: Mon, 19 Dec 2005 14:23:05 -0800 [thread overview]
Message-ID: <43A732C9.2060509@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0512191142410.4827@g5.osdl.org>
Linus Torvalds wrote:
>
> On Mon, 19 Dec 2005, Junio C Hamano wrote:
>
>>I was looking at "git grep -n EAGAIN" output and found that many
>>places check "errno == EAGAIN" without checking "errno ==
>>EINTR", both for read(2) and write(2).
>
>
> I suspect it's mostly in my code. It's a stupid quirk of mine.
>
> You might as well delete those thing, but yes, if you want to replace them
> with testing both EAGAIN and EINTR, go right ahead.
>
It might be that some of those should either be replaced by fwrite/fread
or there should be a generic wrapper (usually called xwrite/xread).
-hpa
next prev parent reply other threads:[~2005-12-19 22:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-19 10:07 EAGAIN? Junio C Hamano
2005-12-19 19:46 ` EAGAIN? Linus Torvalds
2005-12-19 22:23 ` H. Peter Anvin [this message]
2005-12-20 0:55 ` [PATCH] xread/xwrite: do not worry about EINTR at calling sites Junio C Hamano
2005-12-20 10:40 ` Johannes Schindelin
2005-12-20 18:59 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43A732C9.2060509@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.