From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Knorr Subject: Re: pfn_pte/pfn_pmd Date: Wed, 21 Dec 2005 15:25:56 +0100 Message-ID: <43A965F4.1010203@suse.de> References: <43A9401F.76F0.0078.0@novell.com> <43A94AE7.76F0.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <43A94AE7.76F0.0078.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org > I still wonder, however, whether the BUG()/panic() in PAE's pfn_pmd() > couldn't be removed... Wonder why it is still in there though, seems pfn_pmd() is never ever used, checking code ... Ok, seems they are needed for 2M/4M pages, we don't support these anyway, so BUG()'ing in case this is called looks perfectly fine. The panic msg probably should be changed to something more reasonable, such as "Huh? Who tried to use 2M pages?" maybe ;) cheers, Gerd