Re: [PATCH] lpfc: Timer fix

[James Smart <James.Smart@Emulex.Com>]

Agreed.

-- james s

Mark Haverkamp wrote:
> James,
> 
> I've been doing some testing with the lpfc driver and started running
> into some BUG_ON problems using add_timer in lpfc_els_timeout_handler.
> I'm not certain, but I think that the add_timer call should be a
> mod_timer.
> Please take a look.
> 
> Signed-of-by: Mark Haverkamp <markh@osdl.org>
> 
> ---
> 
> Index: scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c
> ===================================================================
> --- scsi-misc-2.6.orig/drivers/scsi/lpfc/lpfc_els.c	2005-12-16 13:14:37.000000000 -0800
> +++ scsi-misc-2.6/drivers/scsi/lpfc/lpfc_els.c	2005-12-16 13:14:53.000000000 -0800
> @@ -2935,8 +2935,7 @@
>  			lpfc_sli_release_iocbq(phba, piocb);
>  	}
>  	if (phba->sli.ring[LPFC_ELS_RING].txcmplq_cnt) {
> -		phba->els_tmofunc.expires = jiffies + HZ * timeout;
> -		add_timer(&phba->els_tmofunc);
> +		mod_timer(&phba->els_tmofunc, jiffies + HZ * timeout);
>  	}
>  	spin_unlock_irq(phba->host->host_lock);
>  }
>