Re: [PATCH] ipv6 support for libnetfilter_conntrack

[Pablo Neira Ayuso <pablo@eurodev.net>]

Yasuyuki KOZAKAI wrote:
>>>And in __parse_inetaddr() in conntrack-ipv6.patch,
>>>
>>>+	else if (inet_pton(AF_INET6, cp, &parse->addr6))
>>>+		return AF_INET6;
>>>
>>>this should be
>>>
>>>+	else if (inet_pton(AF_INET6, cp, &parse->addr6) > 0)
>>>+		return AF_INET6;
>>>
>>>The only positive return value means success.
>>
>>I must be missing anything. From inet_pton manpage:
>>
>>The inet_pton() function shall return 1 if the  conversion succeeds,
>>with the  address  pointed  to  by dst in network byte order. It shall
>>return 0 if the input is not a valid IPv4 dotted-decimal string or a
>>valid  IPv6  address string,  or -1 with errno set to [EAFNOSUPPORT] if
>>the af argument is unknown.
>>
>>Still required such change? Thanks!
> 
> I think nowadays inet_pton() in almost distributions support AF_INET6, too.
> But I don't want to assume that.

OK. I'll also add some extra checkings for inet_pton() at ./configure stage.

-- 
Pablo