All of lore.kernel.org
 help / color / mirror / Atom feed
From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Patch: abituguru driver version 1.1.1
Date: Sat, 24 Dec 2005 20:33:29 +0000	[thread overview]
Message-ID: <43ADB099.7020002@gmail.com> (raw)
In-Reply-To: <43AD5940.1090900@hhs.nl>

Hans de Goede wrote:

>
>/* This is needed untill this gets merged upstream */
>#ifndef __SENSOR_DEVICE_ATTR2
>#define __SENSOR_DEVICE_ATTR2(_name,_mode,_show,_store,_index,_nr)	\
>{	.dev_attr =	__ATTR(_name,_mode,_show,_store),		\
>	.index =	_index,						\
>	.nr =		_nr						\
>}
>#endif
>
>  
>


your macro is nearly identical to one thats already in mainline,
except that your _nr and _index are in a different order.


#define SENSOR_DEVICE_ATTR_2(_name,_mode,_show,_store,_nr,_index)       \
struct sensor_device_attribute_2 sensor_dev_attr_##_name = {    \
        .dev_attr =     __ATTR(_name,_mode,_show,_store),       \
        .index =        _index,                                 \
        .nr =           _nr,                                    \
}



also, I understand why you chose the __ to start the macro name,
but Jean has proposed SENSOR_ATTR(), so I sent a patch
to follow that pattern, adding  SENSOR_ATTR_2()

http://lists.lm-sensors.org/pipermail/lm-sensors/2005-December/014768.html

I trust that Jean will make a choice for us at some point soon.


  reply	other threads:[~2005-12-24 20:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-24 14:20 [lm-sensors] Patch: abituguru driver version 1.1.1 Hans de Goede
2005-12-24 20:33 ` Jim Cromie [this message]
2005-12-25  7:21 ` Hans de Goede
2006-01-24 15:18 ` Rudolf Marek
2006-01-27 20:15 ` Hans de Goede
2006-01-28 10:20 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ADB099.7020002@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.