All of lore.kernel.org
 help / color / mirror / Atom feed
From: j.w.r.degoede@hhs.nl (Hans de Goede)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Patch: abituguru driver version 1.1.1
Date: Sun, 25 Dec 2005 07:21:06 +0000	[thread overview]
Message-ID: <43AE4862.5040001@hhs.nl> (raw)
In-Reply-To: <43AD5940.1090900@hhs.nl>



Jim Cromie wrote:
> Hans de Goede wrote:
> 
>> /* This is needed untill this gets merged upstream */
>> #ifndef __SENSOR_DEVICE_ATTR2
>> #define __SENSOR_DEVICE_ATTR2(_name,_mode,_show,_store,_index,_nr)	\
>> {	.dev_attr =	__ATTR(_name,_mode,_show,_store),		\
>> 	.index =	_index,						\
>> 	.nr =		_nr						\
>> }
>> #endif
>>
>>  
>>
> 
> 
> your macro is nearly identical to one thats already in mainline,
> except that your _nr and _index are in a different order.
> 

Erm,

I took this macro from some patch that was submitted to lm_sensors, 
assuming that this is what it would become in mainline, hence also the 
#ifndef around it.

> 
> #define SENSOR_DEVICE_ATTR_2(_name,_mode,_show,_store,_nr,_index)       \
> struct sensor_device_attribute_2 sensor_dev_attr_##_name = {    \
>         .dev_attr =     __ATTR(_name,_mode,_show,_store),       \
>         .index =        _index,                                 \
>         .nr =           _nr,                                    \
> }
> 

This won't work for me as it declares one struct, where as I'm 
initialising an array of struct AFAIK, that is the difference between 
SENSOR_DEVICE_ATTR(...) and __SENSOR_DEVICE_ATTR(...), just like __ATTR 
can be used to initialise an array of plain sysfs device file attributes.

Regards,

Hans


  parent reply	other threads:[~2005-12-25  7:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-24 14:20 [lm-sensors] Patch: abituguru driver version 1.1.1 Hans de Goede
2005-12-24 20:33 ` Jim Cromie
2005-12-25  7:21 ` Hans de Goede [this message]
2006-01-24 15:18 ` Rudolf Marek
2006-01-27 20:15 ` Hans de Goede
2006-01-28 10:20 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43AE4862.5040001@hhs.nl \
    --to=j.w.r.degoede@hhs.nl \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.