From: Albert Lee <albertcc@tw.ibm.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>, Doug Maxey <dwm@maxeymade.com>
Subject: [PATCH 2/2] libata-dev: filter out noisy ATAPI error messages
Date: Mon, 26 Dec 2005 16:48:00 +0800 [thread overview]
Message-ID: <43AFAE40.4030407@tw.ibm.com> (raw)
Jeff,
Patch 2/2: Minor patch to filter out noisy ATAPI error messages.
Changes:
- Filter out ATAPI packet command error messages in ata_pio_error()
- Filter out ATAPI packet command error messages in ata_host_intr()
Patch against the libata-dev irq-pio branch
(3d0a59c02303df01848537b3bf938dc11e9a0ded).
For your review, thanks.
Albert
Signed-off-by: Albert Lee <albertcc@tw.ibm.com>
======
--- err_mask/drivers/scsi/libata-core.c 2005-12-26 14:59:53.000000000 +0800
+++ noisy_err_msg/drivers/scsi/libata-core.c 2005-12-26 15:06:11.000000000 +0800
@@ -3464,11 +3464,12 @@ static void ata_pio_error(struct ata_por
{
struct ata_queued_cmd *qc;
- printk(KERN_WARNING "ata%u: PIO error\n", ap->id);
-
qc = ata_qc_from_tag(ap, ap->active_tag);
assert(qc != NULL);
+ if (qc->tf.command != ATA_CMD_PACKET)
+ printk(KERN_WARNING "ata%u: PIO error\n", ap->id);
+
/* make sure qc->err_mask is available to
* know what's wrong and recover
*/
@@ -4348,8 +4349,9 @@ fsm_start:
break;
case HSM_ST_ERR:
- printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
- ap->id, status, host_stat);
+ if (qc->tf.command != ATA_CMD_PACKET)
+ printk(KERN_ERR "ata%u: command error, drv_stat 0x%x host_stat 0x%x\n",
+ ap->id, status, host_stat);
/* make sure qc->err_mask is available to
* know what's wrong and recover
reply other threads:[~2005-12-26 8:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43AFAE40.4030407@tw.ibm.com \
--to=albertcc@tw.ibm.com \
--cc=dwm@maxeymade.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.