From: "H. Peter Anvin" <hpa@zytor.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git list <git@vger.kernel.org>
Subject: Re: [PATCH 2/4] short circuit out of a few places where we would allocate zero bytes
Date: Tue, 27 Dec 2005 20:22:42 -0800 [thread overview]
Message-ID: <43B21312.50603@zytor.com> (raw)
In-Reply-To: <20051224121243.GA3963@mail.yhbt.net>
Eric Wong wrote:
> dietlibc versions of malloc, calloc and realloc all return NULL if
> they're told to allocate 0 bytes, causes the x* wrappers to die().
>
> There are several more places where these calls could end up asking
> for 0 bytes, too...
>
> Maybe simply not die()-ing in the x* wrappers if 0/NULL is returned
> when the requested size is zero is a safer and easier way to go.
>
Better yet, either always return NULL or allocate 1 byte in that case,
to get consistent behaviour.
-hpa
next prev parent reply other threads:[~2005-12-28 4:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-24 12:10 [PATCH 0/4] dietlibc compatibility Eric Wong
2005-12-24 12:11 ` [PATCH 1/4] git.c: extra #include for dietlibc (and possibly other C libraries) Eric Wong
2005-12-26 17:01 ` Junio C Hamano
2005-12-24 12:12 ` [PATCH 2/4] short circuit out of a few places where we would allocate zero bytes Eric Wong
2005-12-24 12:44 ` Johannes Schindelin
2005-12-28 4:22 ` H. Peter Anvin [this message]
2005-12-28 4:38 ` Linus Torvalds
2005-12-28 5:07 ` Junio C Hamano
2005-12-28 16:58 ` H. Peter Anvin
2005-12-24 12:13 ` [PATCH 3/4] add xmktime() function that always accounts for the TZ env Eric Wong
2005-12-24 12:45 ` Johannes Schindelin
2005-12-24 19:18 ` Junio C Hamano
2005-12-24 19:52 ` Eric Wong
2005-12-24 21:10 ` Junio C Hamano
2005-12-24 12:14 ` [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} Eric Wong
2005-12-24 18:28 ` Junio C Hamano
2005-12-24 21:15 ` Eric Wong
2005-12-26 18:16 ` [PATCH] Avoid allocating 0 bytes, was " Johannes Schindelin
2005-12-26 19:10 ` Junio C Hamano
2005-12-26 20:34 ` Johannes Schindelin
2005-12-26 22:03 ` [PATCH] avoid asking ?alloc() for zero bytes Junio C Hamano
2005-12-26 22:18 ` Johannes Schindelin
2005-12-28 20:38 ` [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} Johannes Schindelin
2005-12-30 23:00 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B21312.50603@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.