From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Eric Wong <normalperson@yhbt.net>, git list <git@vger.kernel.org>
Subject: Re: [PATCH 2/4] short circuit out of a few places where we would allocate zero bytes
Date: Wed, 28 Dec 2005 08:58:51 -0800 [thread overview]
Message-ID: <43B2C44B.1070102@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0512272036380.14098@g5.osdl.org>
Linus Torvalds wrote:
>
> On Tue, 27 Dec 2005, H. Peter Anvin wrote:
>
>>Better yet, either always return NULL or allocate 1 byte in that case, to get
>>consistent behaviour.
>
> Yes. However, if you do the "return NULL" case (which is nicest), you'll
> have to wrap "free()" too. There are some libraries where passing "free()"
> a NULL pointer causes a SIGSEGV.
>
> That said, I think that would be preferable to changing the source code to
> unnecessarily avoid zero-sized allocations. Having a "xfree()" to match
> "xmalloc()" makes sense.
>
Yeah, although that might break GNU code which uses xmalloc that is
included (GNU doesn't have xfree.) The easiest is just to allocate 1
byte when the user asks for 0.
Anyone knows what GNU xmalloc does?
-hpa
next prev parent reply other threads:[~2005-12-28 16:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-24 12:10 [PATCH 0/4] dietlibc compatibility Eric Wong
2005-12-24 12:11 ` [PATCH 1/4] git.c: extra #include for dietlibc (and possibly other C libraries) Eric Wong
2005-12-26 17:01 ` Junio C Hamano
2005-12-24 12:12 ` [PATCH 2/4] short circuit out of a few places where we would allocate zero bytes Eric Wong
2005-12-24 12:44 ` Johannes Schindelin
2005-12-28 4:22 ` H. Peter Anvin
2005-12-28 4:38 ` Linus Torvalds
2005-12-28 5:07 ` Junio C Hamano
2005-12-28 16:58 ` H. Peter Anvin [this message]
2005-12-24 12:13 ` [PATCH 3/4] add xmktime() function that always accounts for the TZ env Eric Wong
2005-12-24 12:45 ` Johannes Schindelin
2005-12-24 19:18 ` Junio C Hamano
2005-12-24 19:52 ` Eric Wong
2005-12-24 21:10 ` Junio C Hamano
2005-12-24 12:14 ` [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} Eric Wong
2005-12-24 18:28 ` Junio C Hamano
2005-12-24 21:15 ` Eric Wong
2005-12-26 18:16 ` [PATCH] Avoid allocating 0 bytes, was " Johannes Schindelin
2005-12-26 19:10 ` Junio C Hamano
2005-12-26 20:34 ` Johannes Schindelin
2005-12-26 22:03 ` [PATCH] avoid asking ?alloc() for zero bytes Junio C Hamano
2005-12-26 22:18 ` Johannes Schindelin
2005-12-28 20:38 ` [PATCH] Avoid allocating 0 bytes, was Re: [PATCH 4/4] git-compat-util.h: dietlibc-friendly x{malloc,realloc,calloc} Johannes Schindelin
2005-12-30 23:00 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43B2C44B.1070102@zytor.com \
--to=hpa@zytor.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.