All of lore.kernel.org
 help / color / mirror / Atom feed
From: jim.cromie@gmail.com (Jim Cromie)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] hwmon-sensor-attr-array-2.patch
Date: Wed, 28 Dec 2005 21:43:23 +0000	[thread overview]
Message-ID: <43B306FB.9040301@gmail.com> (raw)

Hi Jean, Hans,

This patch refactors SENSOR_DEVICE_ATTR_2 macro, following pattern set by
SENSOR_ATTR.  First it creates a new macro SENSOR_ATTR_2() which expands 
to an initialization expression, then it uses that in SENSOR_DEVICE_ATTR_2, 
which declares and initializes a struct sensor_device_attribute_2.


This version differs from that in Hans' abituguru driver,
in that it preserves the argument order used in the original 
SENSOR_DEVICE_ATTR_2 macro, Hans' version invites confusion by
transposing _nr and _index between 2 closely related macros.

Happily though, Hans coded with __SENSOR_DEVICE_ATTR2,
so his driver could coexist with the macro defined here,
and he could switch at his discretion.

Signed-off-by:  Jim Cromie <jim.cromie at gmail.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hwmon-sensor-attr-array-2.patch
Type: text/x-patch
Size: 969 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20051228/ba4081e3/hwmon-sensor-attr-array-2.bin

             reply	other threads:[~2005-12-28 21:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-28 21:43 Jim Cromie [this message]
2006-01-02 10:01 ` [lm-sensors] hwmon-sensor-attr-array-2.patch Jean Delvare
2006-01-02 10:51 ` Hans de Goede
2006-01-02 19:20 ` Jim Cromie
2006-01-05  4:52 ` Jim Cromie
2006-01-05  8:12 ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43B306FB.9040301@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.