All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Gerst <bgerst@didntduck.org>
To: Horst von Brand <vonbrand@inf.utfsm.cl>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Split out screen_info from tty.h
Date: Thu, 29 Dec 2005 12:00:41 -0500	[thread overview]
Message-ID: <43B41639.6060301@didntduck.org> (raw)
In-Reply-To: <200512291639.jBTGdfLZ015516@laptop11.inf.utfsm.cl>

Horst von Brand wrote:
> Brian Gerst <bgerst@didntduck.org> wrote:
>> This makes it possible for boot code to use screen_info without dragging in
>> all of tty.h.
> 
> Why is that a problem? Introducing yet another .h that developers have to
> remember and use appropiately has a cost, so... and I see no changes except
> for different #include lines in your patch.

x86_64 carried a copy of screen_info in miscsetup.h which was out of
date with the master copy in tty.h.  It couldn't include the full tty.h
because it is compiling in 32-bit mode (causes warnings from unrelated
junk in tty.h).  Splitting it out means that x86_64 can get the bare
minimum it needs to compile the boot loader while having the definition
in one place.

--
				Brian Gerst

      reply	other threads:[~2005-12-29 17:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-28 21:50 [PATCH] Split out screen_info from tty.h Brian Gerst
2005-12-29 16:39 ` Horst von Brand
2005-12-29 17:00   ` Brian Gerst [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43B41639.6060301@didntduck.org \
    --to=bgerst@didntduck.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vonbrand@inf.utfsm.cl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.