From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EsMtY-0000gk-QQ for qemu-devel@nongnu.org; Fri, 30 Dec 2005 11:14:21 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EsMtW-0000f0-Lf for qemu-devel@nongnu.org; Fri, 30 Dec 2005 11:14:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EsMtW-0000ek-Dj for qemu-devel@nongnu.org; Fri, 30 Dec 2005 11:14:18 -0500 Received: from [193.252.22.27] (helo=smtp4.wanadoo.fr) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EsMu4-0004D3-6i for qemu-devel@nongnu.org; Fri, 30 Dec 2005 11:14:52 -0500 Received: from me-wanadoo.net (localhost [127.0.0.1]) by mwinf0402.wanadoo.fr (SMTP Server) with ESMTP id 414911C001AC for ; Fri, 30 Dec 2005 17:12:48 +0100 (CET) Received: from [192.168.1.102] (AMontpellier-251-1-37-54.w81-251.abo.wanadoo.fr [81.251.85.54]) by mwinf0402.wanadoo.fr (SMTP Server) with ESMTP id D46561C0016B for ; Fri, 30 Dec 2005 17:12:43 +0100 (CET) Message-ID: <43B5B156.5030007@bellard.org> Date: Fri, 30 Dec 2005 17:14:46 -0500 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] lba48 support References: <20051229220752.GP2772@suse.de> In-Reply-To: <20051229220752.GP2772@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jens Axboe wrote: > Saw the posts on this the other day and had a few spare hours to play > with this. Works for me, with and without DMA (didn't test mult mode, > but that should work fine too). > > Test with caution though, it's changing the ide code so could eat your > data if there's a bug there... Most clever OS's don't use lba48 even for > lba48 capable drives, unless the device is > 2^28 sectors and the > current request is past that (but they could be taking advantage of the > larger transfer size possible, in which case lba48 will be used even for > low sectors...). Thank you for the patch ! At least two details should be corrected before I can apply it: 1) Each duplicated IDE register acts as a 2 byte FIFO, so the logic you added in the write function should be modified (the regs_written field is not needed). 2) The read back logic should be implemented (HOB bit in the device control register). Fabrice.