Re: mdadm-2.2 SEGFAULT: mdadm --assemble --scan

[Andreas Haumer <andreas@xss.co.at>]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi!

Andre Noll schrieb:
> sorry if this is already known/fixed: Assemble() is called from mdadm.c with
> the "update" argument equal to NULL:
> 
> 	Assemble(ss, array_list->devname, mdfd, array_list, configfile,
> 		NULL, readonly, runstop, NULL, verbose-quiet, force);
> 
> But in Assemble.c we have
> 
> 	if (ident->uuid_set && (!update && strcmp(update, "uuid")!= 0) && ...
> 
> which yields a segfault in glibc's strcmp().
> 
I just found the same problem after upgrading to mdadm-2.2
The logic to test for update not being NULL seems to be
reversed.

I created a small patch which seems to cure the problem
(see attached file)

HTH

- - andreas

- --
Andreas Haumer                     | mailto:andreas@xss.co.at
*x Software + Systeme              | http://www.xss.co.at/
Karmarschgasse 51/2/20             | Tel: +43-1-6060114-0
A-1100 Vienna, Austria             | Fax: +43-1-6060114-71
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDtqD0xJmyeGcXPhERAsdiAJ0Ve787gscq4VOGtT+9Qp3k62iUEgCgs9pH
Ekg0gkLEk+99XXHw+1ezdu8=
=rh66
-----END PGP SIGNATURE-----

[-- Attachment #2: update_uuid.patch --]
[-- Type: text/plain, Size: 697 bytes --]

Index: mdadm/Assemble.c
===================================================================
RCS file: /home/cvs/repository/distribution/Utilities/mdadm/Assemble.c,v
retrieving revision 1.1.1.7
diff -u -r1.1.1.7 Assemble.c
--- mdadm/Assemble.c	5 Dec 2005 05:56:20 -0000	1.1.1.7
+++ mdadm/Assemble.c	31 Dec 2005 15:01:34 -0000
@@ -219,7 +219,7 @@
 		}
 		if (dfd >= 0) close(dfd);
 
-		if (ident->uuid_set && (!update && strcmp(update, "uuid")!= 0) &&
+		if (ident->uuid_set && (update && strcmp(update, "uuid")!= 0) &&
 		    (!super || same_uuid(info.uuid, ident->uuid, tst->ss->swapuuid)==0)) {
 			if ((inargv && verbose >= 0) || verbose > 0)
 				fprintf(stderr, Name ": %s has wrong uuid.\n",