All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <slaby@liberouter.org>
To: Jason Dravet <dravet@hotmail.com>
Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org
Subject: Re: RFC: add udev support to parport_pc
Date: Sat, 31 Dec 2005 18:59:15 +0100	[thread overview]
Message-ID: <43B6C6F3.7080109@liberouter.org> (raw)
In-Reply-To: <BAY103-F5ABE5F52E47CC9DD71D21DF2B0@phx.gbl>

Jason Dravet napsal(a):
> Here is a patch to parport_pc.c that adds udev support.  Without it
> sysfs does not have enough information to give to udev so the lp and
> parport nodes can be created.  The only problem I have is the
> kernel_oops when I do the following: insmod parport, insmod parport_pc,
> rmmod parport_pc, rmmod parport, insmod parport, insmod parport_pc,
> rmmod parport_pc, kernel oops. 
[snip]
> +    if (p->base == 888) /* 888 is dec for 378h */
> +    {
> +        class_device_create(parallel_class, NULL, MKDEV(6, 0), NULL,
> "lp0");
> +        class_device_create(parallel_class, NULL, MKDEV(99, 0), NULL,
> "parport0");
> +    }
use please
if () {
}
instead of
if ()
{
}
like the surrounding code

thanks,
-- 
Jiri Slaby         www.fi.muni.cz/~xslaby
\_.-^-._   jirislaby@gmail.com   _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E

  parent reply	other threads:[~2005-12-31 17:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-31 17:20 RFC: add udev support to parport_pc Jason Dravet
2005-12-31 17:38 ` Jan Engelhardt
2005-12-31 18:07   ` Jason Dravet
2005-12-31 20:50     ` Jan Engelhardt
2005-12-31 19:22   ` Jason Dravet
2005-12-31 17:59 ` Jiri Slaby [this message]
2005-12-31 18:14   ` Jason Dravet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43B6C6F3.7080109@liberouter.org \
    --to=slaby@liberouter.org \
    --cc=dravet@hotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parport@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.