All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stas Sergeev <stsp@aknet.ru>
To: Adrian Bunk <bunk@stusta.de>
Cc: Steve Work <swork@aventail.com>,
	linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: Multi-thread corefiles broken since April
Date: Sun, 01 Jan 2006 04:18:52 +0300	[thread overview]
Message-ID: <43B72DFC.4070707@aknet.ru> (raw)
In-Reply-To: <20051231142851.GH3811@stusta.de>

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

Hi.

Adrian Bunk wrote:
> On Wed, Dec 07, 2005 at 10:52:52PM -0800, Steve Work wrote:
>> Or do the corefile 
>> write routines need to know about this adjusted offset?
I think so, the attached patch seem to help.

Happy new year and happy hacking!


-----
teach dump_task_regs() about the -8 offset.

Signed-off-by: stsp@aknet.ru


[-- Attachment #2: stkfix.diff --]
[-- Type: text/x-patch, Size: 492 bytes --]

--- linux/arch/i386/kernel/process.c.old	2005-08-07 21:58:25.000000000 +0400
+++ linux/arch/i386/kernel/process.c	2006-01-01 03:03:10.000000000 +0300
@@ -573,7 +573,9 @@
 	struct pt_regs ptregs;
 	
 	ptregs = *(struct pt_regs *)
-		((unsigned long)tsk->thread_info+THREAD_SIZE - sizeof(ptregs));
+		((unsigned long)tsk->thread_info +
+		/* see comments in copy_thread() about -8 */
+		THREAD_SIZE - sizeof(ptregs) - 8);
 	ptregs.xcs &= 0xffff;
 	ptregs.xds &= 0xffff;
 	ptregs.xes &= 0xffff;

      reply	other threads:[~2006-01-01  1:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-08  6:52 Multi-thread corefiles broken since April Steve Work
2005-12-11  0:44 ` Andrew Morton
2005-12-31 14:28 ` Adrian Bunk
2006-01-01  1:18   ` Stas Sergeev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43B72DFC.4070707@aknet.ru \
    --to=stsp@aknet.ru \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swork@aventail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.