From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EtVsA-0001EZ-VX for mharc-grub-devel@gnu.org; Mon, 02 Jan 2006 15:01:39 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EtVs8-0001AO-Iq for grub-devel@gnu.org; Mon, 02 Jan 2006 15:01:36 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EtVs4-00011W-7S for grub-devel@gnu.org; Mon, 02 Jan 2006 15:01:36 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EtVs4-00011R-3W for grub-devel@gnu.org; Mon, 02 Jan 2006 15:01:32 -0500 Received: from [208.186.28.7] (helo=mail.nebonet.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EtVtA-0008OE-61 for grub-devel@gnu.org; Mon, 02 Jan 2006 15:02:40 -0500 Received: from localhost (scanner.nebonet.com [208.186.28.8]) by mail.nebonet.com (Postfix) with ESMTP id 75E2519DF1D for ; Mon, 2 Jan 2006 12:59:51 -0700 (MST) Received: from mail.nebonet.com ([208.186.28.7]) by localhost (scanner.nebonet.com [208.186.28.8]) (amavisd-new, port 10024) with LMTP id 28954-03 for ; Mon, 2 Jan 2006 12:59:44 -0700 (MST) Received: from [10.0.1.114] (f4s.dsl.xmission.com [166.70.40.38]) by mail.nebonet.com (Postfix) with ESMTP id 1F12E19DF27 for ; Mon, 2 Jan 2006 12:53:58 -0700 (MST) Message-ID: <43B984C7.6070502@omniflux.com> Date: Mon, 02 Jan 2006 12:53:43 -0700 From: Omniflux User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: The development of GRUB 2 References: <43B1DD7E.5090905@omniflux.com> <87y8219p48.fsf@xs4all.nl> In-Reply-To: <87y8219p48.fsf@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Debian amavisd-new at scanner.nebonet.com Subject: Re: [PATCH] User definable terminfo support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 20:01:37 -0000 Marco Gerards wrote: >>terminfo-definition-support.diff >> * term/terminfo.c: Replaced static vt100 definition with user >>definable definition support. > > Is it possible to do this in a GRUB env. variable, like: > > set TERM=vt100 > > And perhaps one variable or function to set the possible terminal > descriptions. I think that would be easier for the user to do it this > way. > This is possible, however... The reason I chose to use a linked list allowing multiple terminal definitions was so multiple entries could be defined at load time, and, ideally, the user could then choose the correct one at boot. This would be helpful in cases where the choice of definitions is unknown to the entity creating the configuration, such as a live CD distribution or a generalized system recovery disk for computers without video cards. As to using an env. variable to select which terminal definition to use, I have not looked at the env. code. I doubt I can tie into the env. code to tell when the variable has changed, so this would leave the problem of no immediate user feedback if an invalid definition name is set. If you can point to a good place to provide this feedback, I see no problem with changing the selection code to use an environment variable instead, but I would like to keep support for multiple terminfo definitions. Did I interpret your comments correctly? > give will be more useful than the feedback above... Can you provide a > ChangeLog entry so the patch can be reviewed and applied? See the GNU Should this be provided as part of the patch, or separate, but with the patch email? > At the moment I am working on the menu code, so the syntax will be > changed really soon. But at the moment you can do something like: > > title foo > linux /vmlinux ... > > title bar > ... I will try this. Thanks! -- Omniflux