From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EtWEY-00007T-PL for mharc-grub-devel@gnu.org; Mon, 02 Jan 2006 15:24:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EtWEX-00007F-Ap for grub-devel@gnu.org; Mon, 02 Jan 2006 15:24:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EtWEV-00006z-QU for grub-devel@gnu.org; Mon, 02 Jan 2006 15:24:45 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EtWEV-00006r-HX for grub-devel@gnu.org; Mon, 02 Jan 2006 15:24:43 -0500 Received: from [208.186.28.7] (helo=mail.nebonet.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EtWFb-0003qr-U8 for grub-devel@gnu.org; Mon, 02 Jan 2006 15:25:52 -0500 Received: from localhost (scanner.nebonet.com [208.186.28.8]) by mail.nebonet.com (Postfix) with ESMTP id E923719DF08 for ; Mon, 2 Jan 2006 13:23:02 -0700 (MST) Received: from mail.nebonet.com ([208.186.28.7]) by localhost (scanner.nebonet.com [208.186.28.8]) (amavisd-new, port 10024) with LMTP id 32429-01-3 for ; Mon, 2 Jan 2006 13:22:56 -0700 (MST) Received: from [10.0.1.114] (f4s.dsl.xmission.com [166.70.40.38]) by mail.nebonet.com (Postfix) with ESMTP id E9F0019DA2A for ; Mon, 2 Jan 2006 13:21:58 -0700 (MST) Message-ID: <43B98B57.3@omniflux.com> Date: Mon, 02 Jan 2006 13:21:43 -0700 From: Omniflux User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: en-us, en MIME-Version: 1.0 To: The development of GRUB 2 References: <43B1DD7E.5090905@omniflux.com> <878xtyjtxm.fsf@xs4all.nl> In-Reply-To: <878xtyjtxm.fsf@xs4all.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: Debian amavisd-new at scanner.nebonet.com Subject: Re: [PATCH] User definable terminfo support X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2006 20:24:45 -0000 Marco Gerards wrote: > Here is the review of the code that I promised. Please see my other > email about generic comments. What is the subject line of this message? I sadly do not read all messages on this list. > You can put the string on a new line. If the string is still too long > you can make two strings out of it, like: > > grub_error (FOO, > "bar" > "baz"); grub_error (FOO, "bar" "baz"); No operator or separator between strings? >>+ ti->name = grub_strdup (args[0]); > > > Typo. Can you be more specific? This looks correct to me... >>+static void >>+setup_defaults (void) >>+{ >>+ terminfo_t *ti; >>+ >>+ ti = (terminfo_t *) grub_malloc (sizeof (terminfo_t)); >>+ /* Do I need to test if malloc succeeded here? What do I do if it did not? */ > > > Good one :-) > > In that case default could be set to NULL, if that is allowed? I think in this case, there will be many other problems. I think the best thing in this case will be, as you suggest, to set the definition to NULL and have all terminfo functions return their strings unmodified. The only consequence to this I can think of is loss of menu support on terminals which depend on terminfo (serial), and should be a rare case even there. -- Omniflux